Skip to content

Commit 1d3b895

Browse files
committed
MC-37922: Html tag <br> visible in message
1 parent 2cf0433 commit 1d3b895

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

app/code/Magento/ImportExport/Controller/Adminhtml/ImportResult.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,12 +69,16 @@ protected function addErrorMessages(
6969
if ($errorAggregator->getErrorsCount()) {
7070
$message = '';
7171
$counter = 0;
72+
$unescapedMessages = [];
7273
foreach ($this->getErrorMessages($errorAggregator) as $error) {
73-
$message .= (++$counter) . '. ' . $error . '<br>';
74+
$unescapedMessages[] = (++$counter) . '. ' . $error;
7475
if ($counter >= self::LIMIT_ERRORS_MESSAGE) {
7576
break;
7677
}
7778
}
79+
foreach ($unescapedMessages as $unescapedMessage) {
80+
$message .= $resultBlock->escapeHtml($unescapedMessage) . '<br>';
81+
}
7882
if ($errorAggregator->hasFatalExceptions()) {
7983
foreach ($this->getSystemExceptions($errorAggregator) as $error) {
8084
$message .= $error->getErrorMessage()
@@ -90,7 +94,7 @@ protected function addErrorMessages(
9094
. '<a href="'
9195
. $this->createDownloadUrlImportHistoryFile($this->createErrorReport($errorAggregator))
9296
. '">' . __('Download full report') . '</a><br>'
93-
. '<div class="import-error-list">' . $resultBlock->escapeHtml($message) . '</div></div>'
97+
. '<div class="import-error-list">' . $message . '</div></div>'
9498
);
9599
} catch (\Exception $e) {
96100
foreach ($this->getErrorMessages($errorAggregator) as $errorMessage) {

0 commit comments

Comments
 (0)