magento/graphql-ce#1061: Remove redundant logic from resolvers

Author: lenaorobei

app/code/Magento/AuthorizenetGraphQl/Model/AuthorizenetDataProvider.php

@@ -49,21 +49,6 @@ public function getData(array $data): array
                 __('Required parameter "authorizenet_acceptjs" for "payment_method" is missing.')
             );
         }
-        if (!isset($data[self::PATH_ADDITIONAL_DATA]['opaque_data_descriptor'])) {
-            throw new GraphQlInputException(
-                __('Required parameter "opaque_data_descriptor" for "authorizenet_acceptjs" is missing.')
-            );
-        }
-        if (!isset($data[self::PATH_ADDITIONAL_DATA]['opaque_data_value'])) {
-            throw new GraphQlInputException(
-                __('Required parameter "opaque_data_value" for "authorizenet_acceptjs" is missing.')
-            );
-        }
-        if (!isset($data[self::PATH_ADDITIONAL_DATA]['cc_last_4'])) {
-            throw new GraphQlInputException(
-                __('Required parameter "cc_last_4" for "authorizenet_acceptjs" is missing.')
-            );
-        }
 
         $additionalData = $this->arrayManager->get(static::PATH_ADDITIONAL_DATA, $data);
         foreach ($additionalData as $key => $value) {

app/code/Magento/BraintreeGraphQl/Model/BraintreeDataProvider.php

@@ -31,19 +31,6 @@ public function getData(array $args): array
                 __('Required parameter "braintree" for "payment_method" is missing.')
             );
         }
-
-        if (!isset($args[self::PATH_ADDITIONAL_DATA]['payment_method_nonce'])) {
-            throw new GraphQlInputException(
-                __('Required parameter "payment_method_nonce" for "braintree" is missing.')
-            );
-        }
-
-        if (!isset($args[self::PATH_ADDITIONAL_DATA]['is_active_payment_token_enabler'])) {
-            throw new GraphQlInputException(
-                __('Required parameter "is_active_payment_token_enabler" for "braintree" is missing.')
-            );
-        }
-
         return $args[self::PATH_ADDITIONAL_DATA];
     }
 }

dev/tests/api-functional/testsuite/Magento/GraphQl/Braintree/Customer/SetPaymentMethodTest.php

@@ -380,33 +380,6 @@ private function getSetPaymentBraintreeQueryInvalidInput(string $maskedQuoteId,
 QUERY;
     }
 
-    /**
-     * @param string $maskedQuoteId
-     * @return string
-     */
-    private function getSetPaymentBraintreeQueryInvalidPaymentMethodInput(string $maskedQuoteId): string
-    {
-        return <<<QUERY
-mutation {
-  setPaymentMethodOnCart(input:{
-    cart_id:"{$maskedQuoteId}"
-    payment_method:{
-      code:"braintree"
-      braintree:{
-        payment_method_nonce:"fake-valid-nonce"
-      }
-    }
-  }) {
-    cart {
-      selected_payment_method {
-        code
-      }
-    }
-  }
-}
-QUERY;
-    }
-
     /**
      * @param string $maskedQuoteId
      * @param string $methodCode

dev/tests/api-functional/testsuite/Magento/GraphQl/Braintree/Guest/SetPaymentMethodTest.php

@@ -198,31 +198,6 @@ private function getSetPaymentBraintreeQueryInvalidInput(string $maskedQuoteId):
 QUERY;
     }
 
-    /**
-     * @param string $maskedQuoteId
-     * @return string
-     */
-    private function getSetPaymentBraintreeQueryInvalidMethodInput(string $maskedQuoteId): string
-    {
-        return <<<QUERY
-mutation {
-  setPaymentMethodOnCart(input:{
-    cart_id:"{$maskedQuoteId}"
-    payment_method:{
-      code:"braintree"
-      braintree: {}
-    }
-  }) {
-    cart {
-      selected_payment_method {
-        code
-      }
-    }
-  }
-}
-QUERY;
-    }
-
     /**
      * @param string $maskedQuoteId
      * @return string