Added integration test for checking customer login attempts captcha cleanup after account edit

Author: rogyar

dev/tests/integration/testsuite/Magento/Captcha/Observer/ResetAttemptForFrontendAccountEditObserverTest.php

@@ -0,0 +1,53 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\Captcha\Observer;
+
+use Magento\Captcha\Model\ResourceModel\Log as CaptchaLog;
+use Magento\Captcha\Model\ResourceModel\LogFactory;
+use Magento\Framework\Event\ManagerInterface;
+use Magento\Framework\ObjectManagerInterface;
+
+/**
+ * Class ResetAttemptForFrontendAccountEditObserverTest
+ *
+ * Test for checking that the customer login attempts are removed after account details edit
+ */
+class ResetAttemptForFrontendAccountEditObserverTest extends \PHPUnit\Framework\TestCase
+{
+    /**
+     * @var ObjectManagerInterface
+     */
+    private $objectManager;
+
+    public function setUp()
+    {
+        $this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
+    }
+
+    /**
+     * @magentoDataFixture Magento/Captcha/_files/failed_logins_frontend.php
+     */
+    public function testAccountEditRemovesFailedAttempts()
+    {
+        $customerEmail = 'mageuser@dummy.com';
+        $captchaLogFactory = $this->objectManager->get(LogFactory::class);
+        $eventManager = $this->objectManager->get(ManagerInterface::class);
+
+        $eventManager->dispatch(
+            'customer_account_edited',
+            ['email' => $customerEmail]
+        );
+
+        /**
+         * @var CaptchaLog $captchaLog
+         */
+        $captchaLog = $captchaLogFactory->create();
+
+        self::assertEquals(0, $captchaLog->countAttemptsByUserLogin($customerEmail));
+    }
+}

dev/tests/integration/testsuite/Magento/Captcha/Observer/ResetAttemptForFrontendObserverTest.php

@@ -15,13 +15,12 @@
 use Magento\Framework\ObjectManagerInterface;
 
 /**
- * Class ResetAttemptForBackendObserverTest
+ * Class ResetAttemptForFrontendObserverTest
  *
  * Test for checking that the customer login attempts are removed after a successful login
  */
 class ResetAttemptForFrontendObserverTest extends \PHPUnit\Framework\TestCase
 {
-    const USER_EMAIL = 'mageuser@dummy.com';
     /**
      * @var ObjectManagerInterface
      */
@@ -37,13 +36,14 @@ public function setUp()
      */
     public function testSuccesfulLoginRemovesFailedAttempts()
     {
+        $customerEmail = 'mageuser@dummy.com';
         $customerFactory = $this->objectManager->get(CustomerFactory::class);
         $captchaLogFactory = $this->objectManager->get(LogFactory::class);
         $eventManager = $this->objectManager->get(ManagerInterface::class);
 
         /** @var Customer $customer */
         $customer = $customerFactory->create();
-        $customer->setEmail(self::USER_EMAIL);
+        $customer->setEmail($customerEmail);
 
         $eventManager->dispatch(
             'customer_customer_authenticated',
@@ -55,6 +55,6 @@ public function testSuccesfulLoginRemovesFailedAttempts()
          */
         $captchaLog = $captchaLogFactory->create();
 
-        self::assertEquals(0, $captchaLog->countAttemptsByUserLogin(self::USER_EMAIL));
+        self::assertEquals(0, $captchaLog->countAttemptsByUserLogin($customerEmail));
     }
 }

dev/tests/integration/testsuite/Magento/Captcha/_files/failed_logins_frontend.php

@@ -8,11 +8,10 @@
 use Magento\TestFramework\Helper\Bootstrap;
 use Magento\Captcha\Model\ResourceModel\LogFactory;
 use Magento\Captcha\Model\ResourceModel\Log;
-use Magento\Captcha\Observer\ResetAttemptForFrontendObserverTest;
 
 $objectManager = Bootstrap::getObjectManager();
 $logFactory = $objectManager->get(LogFactory::class);
 
 /** @var Log $captchaLog */
 $captchaLog = $logFactory->create();
-$captchaLog->logAttempt(ResetAttemptForFrontendObserverTest::USER_EMAIL);
+$captchaLog->logAttempt('mageuser@dummy.com');

dev/tests/integration/testsuite/Magento/Captcha/_files/failed_logins_frontend_rollback.php

@@ -8,11 +8,10 @@
 use Magento\TestFramework\Helper\Bootstrap;
 use Magento\Captcha\Model\ResourceModel\LogFactory;
 use Magento\Captcha\Model\ResourceModel\Log;
-use Magento\Captcha\Observer\ResetAttemptForFrontendObserverTest;
 
 $objectManager = Bootstrap::getObjectManager();
 $logFactory = $objectManager->get(LogFactory::class);
 
 /** @var Log $captchaLog */
 $captchaLog = $logFactory->create();
-$captchaLog->deleteUserAttempts(ResetAttemptForFrontendObserverTest::USER_EMAIL);
+$captchaLog->deleteUserAttempts('mageuser@dummy.com');