🔃 [EngCom] Public Pull Requests - 2.1-develop

Accepted Public Pull Requests:
 - #17237: [Backport] Remove commented code (by @tiagosampaio)

Author: Stanislav Idolov

app/code/Magento/Review/Model/ResourceModel/Rating/Collection.php

@@ -138,7 +138,6 @@ public function setStoreFilter($storeId)
                 'main_table.rating_id = store.rating_id',
                 []
             );
-            //        ->group('main_table.rating_id')
             $this->_isStoreJoined = true;
         }
         $inCondition = $connection->prepareSqlCondition('store.store_id', ['in' => $storeId]);

app/code/Magento/Sales/Model/Order/Creditmemo.php

@@ -475,13 +475,6 @@ public function getStateName($stateId = null)
      */
     public function setShippingAmount($amount)
     {
-        // base shipping amount calculated in total model
-        //        $amount = $this->getStore()->round($amount);
-        //        $this->setData('base_shipping_amount', $amount);
-        //
-        //        $amount = $this->getStore()->round(
-        //            $amount*$this->getOrder()->getStoreToOrderRate()
-        //        );
         return $this->setData(CreditmemoInterface::SHIPPING_AMOUNT, $amount);
     }
 

lib/internal/Magento/Framework/Data/Form/Element/Checkboxes.php

@@ -178,14 +178,6 @@ public function getOnchange($value)
         return;
     }
 
-    //    public function getName($value)
-    //    {
-    //        if ($name = $this->getData('name')) {
-    //            return str_replace('$value', $value, $name);
-    //        }
-    //        return ;
-    //    }
-
     /**
      * @param array $option
      * @return string

lib/internal/Magento/Framework/Model/ResourceModel/Db/Relation/ActionPool.php

@@ -50,9 +50,6 @@ public function getActions($entityType, $actionName)
         }
         foreach ($this->relationActions[$entityType][$actionName] as $actionClassName) {
             $action = $this->objectManager->get($actionClassName);
-            //if (!$action instanceof ProcessEntityRelationInterface) {
-            //    throw new \Exception('Not compliant with action interface');
-            //}
             $actions[] = $action;
         }
         return $actions;