Skip to content

Commit 1c8c245

Browse files
committed
Fixed violations:
- Line exceeds maximum limit of characters - Multi-line function call not indented correctly - Only one argument is allowed per line in a multi-line function call - No space found after comma in function call
1 parent 45528b8 commit 1c8c245

File tree

9 files changed

+37
-17
lines changed

9 files changed

+37
-17
lines changed

app/code/Magento/Backend/Block/Dashboard/AbstractDashboard.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66

77
namespace Magento\Backend\Block\Dashboard;
88

9+
use Magento\Framework\Model\ResourceModel\Db\Collection\AbstractCollection;
10+
911
/**
1012
* Adminhtml dashboard tab abstract
1113
*
@@ -38,7 +40,7 @@ public function __construct(
3840
}
3941

4042
/**
41-
* @return array|\Magento\Framework\Model\ResourceModel\Db\Collection\AbstractCollection|\Magento\Eav\Model\Entity\Collection\Abstract
43+
* @return array|AbstractCollection|\Magento\Eav\Model\Entity\Collection\Abstract
4244
*/
4345
public function getCollection()
4446
{

app/code/Magento/Backend/Block/Menu.php

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44
* See COPYING.txt for license details.
55
*/
66

7+
// @codingStandardsIgnoreFile
8+
79
namespace Magento\Backend\Block;
810

911
/**
@@ -146,11 +148,13 @@ protected function _renderMouseEvent($menuItem)
146148
protected function _renderItemCssClass($menuItem, $level)
147149
{
148150
$isLast = 0 == $level && (bool)$this->getMenuModel()->isLast($menuItem) ? 'last' : '';
149-
$output = ($this->menuItemChecker->isItemActive(
151+
$isItemActive = $this->menuItemChecker->isItemActive(
150152
$this->getActiveItemModel(),
151-
$menuItem,
152-
$level
153-
) ? '_current _active' : '') .
153+
$menuItem,
154+
$level
155+
) ? '_current _active' : '';
156+
157+
$output = $isItemActive .
154158
' ' .
155159
($menuItem->hasChildren() ? 'parent' : '') .
156160
' ' .

app/code/Magento/Backend/Block/Page/System/Config/Robots/Reset.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ protected function _construct()
5151
public function getRobotsDefaultCustomInstructions()
5252
{
5353
return trim((string)$this->_scopeConfig->getValue(
54-
self::XML_PATH_ROBOTS_DEFAULT_CUSTOM_INSTRUCTIONS, ScopeConfigInterface::SCOPE_TYPE_DEFAULT
54+
self::XML_PATH_ROBOTS_DEFAULT_CUSTOM_INSTRUCTIONS,
55+
ScopeConfigInterface::SCOPE_TYPE_DEFAULT
5556
));
5657
}
5758

app/code/Magento/Backend/Block/System/Design/Edit/Tab/General.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ protected function _prepareForm()
6464
]
6565
);
6666
$renderer = $this->getLayout()->createBlock(
67-
\Magento\Backend\Block\Store\Switcher\Form\Renderer\Fieldset\Element::class
67+
\Magento\Backend\Block\Store\Switcher\Form\Renderer\Fieldset\Element::class
6868
);
6969
$field->setRenderer($renderer);
7070
} else {

app/code/Magento/Backend/Block/Widget/Grid/Column/Renderer/Action.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,8 @@ protected function _transformActionData(&$action, &$actionCaption, \Magento\Fram
153153
break;
154154

155155
case 'popup':
156-
$action['onclick'] = 'popWin(this.href,\'_blank\',\'width=800,height=700,resizable=1,scrollbars=1\');return false;';
156+
$action['onclick'] = 'popWin(this.href,\'_blank\',\'width=800,height=700,resizable=1,'
157+
. 'scrollbars=1\');return false;';
157158
break;
158159
}
159160
}

app/code/Magento/Backend/Test/Unit/Block/Widget/Grid/ColumnSetTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,8 @@ public function testGetTotals()
322322
);
323323

324324
$this->assertEquals(
325-
new \Magento\Framework\DataObject(['test1' => '3', 'test2' => '2']), $this->_block->getTotals()
325+
new \Magento\Framework\DataObject(['test1' => '3', 'test2' => '2']),
326+
$this->_block->getTotals()
326327
);
327328
}
328329

app/code/Magento/Backend/Test/Unit/Controller/Adminhtml/Cache/CleanMediaTest.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,7 @@ public function testExecute()
7676

7777
$messageManager->expects($this->once())
7878
->method('addSuccess')
79-
->with('The JavaScript/CSS cache has been cleaned.'
80-
);
79+
->with('The JavaScript/CSS cache has been cleaned.');
8180

8281
$valueMap = [
8382
[\Magento\Framework\View\Asset\MergeService::class, $mergeService],

app/code/Magento/Backend/Test/Unit/Controller/Adminhtml/Cache/CleanStaticFilesTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ protected function setUp()
5858

5959
$this->controller = $objectHelper->getObject(
6060
\Magento\Backend\Controller\Adminhtml\Cache\CleanStaticFiles::class,
61-
['context' => $context,]
61+
['context' => $context]
6262
);
6363
}
6464

app/code/Magento/Backend/Test/Unit/Controller/Adminhtml/Dashboard/AbstractTestCase.php

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,19 +23,31 @@ protected function assertExecute($controllerName, $blockName)
2323
$outPut = "data";
2424
$resultRawMock = $this->getMock(
2525
\Magento\Framework\Controller\Result\Raw::class,
26-
['setContents'], [], '', false)
27-
;
26+
['setContents'],
27+
[],
28+
'',
29+
false
30+
);
2831
$resultRawFactoryMock = $this->getMock(
2932
\Magento\Framework\Controller\Result\RawFactory::class,
30-
['create'], [], '', false
33+
['create'],
34+
[],
35+
'',
36+
false
3137
);
3238
$layoutFactoryMock = $this->getMock(
3339
\Magento\Framework\View\LayoutFactory::class,
34-
['create'], [], '', false
40+
['create'],
41+
[],
42+
'',
43+
false
3544
);
3645
$layoutMock = $this->getMock(
3746
\Magento\Framework\View\Layout::class,
38-
['createBlock', 'toHtml'], [], '', false
47+
['createBlock', 'toHtml'],
48+
[],
49+
'',
50+
false
3951
);
4052
$layoutFactoryMock->expects($this->once())->method('create')->will($this->returnValue($layoutMock));
4153
$layoutMock->expects($this->once())->method('createBlock')->with($blockName)->will($this->returnSelf());

0 commit comments

Comments
 (0)