Skip to content

Commit 1c87c22

Browse files
committed
MC-41597: Base UI component for new messages
- fix CR comments
1 parent 3b113fc commit 1c87c22

File tree

6 files changed

+14
-14
lines changed

6 files changed

+14
-14
lines changed

app/code/Magento/Paypal/Block/Bml/Paylater.php renamed to app/code/Magento/Paypal/Block/PayLater/Banner.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@
66

77
declare(strict_types=1);
88

9-
namespace Magento\Paypal\Block\Bml;
9+
namespace Magento\Paypal\Block\PayLater;
1010

1111
use Magento\Framework\View\Element\Template;
1212
use Magento\Paypal\Model\Config;
1313

1414
/**
1515
* PayPal PayLater component block
1616
*/
17-
class Paylater extends Template
17+
class Banner extends Template
1818
{
1919
/**
2020
* @var \Magento\Paypal\Model\Config

app/code/Magento/Paypal/view/frontend/layout/catalog_product_view.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<argument name="position" xsi:type="number">0</argument>
1515
</arguments>
1616
</block>
17-
<block class="Magento\Paypal\Block\Bml\Paylater" name="paylater.center.logo"
17+
<block class="Magento\Paypal\Block\PayLater\Banner" name="paylater.center.logo"
1818
template="Magento_Paypal::paylater.phtml">
1919
<arguments>
2020
<argument name="jsLayout" xsi:type="array">

app/code/Magento/Paypal/view/frontend/templates/paylater.phtml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* See COPYING.txt for license details.
55
*/
66

7-
/** @var $block \Magento\Paypal\Block\Bml\Paylater */
7+
/** @var $block \Magento\Paypal\Block\PayLater\Banner */
88
?>
99
<div id="pay-later" data-bind="scope: 'payLater'">
1010
<!-- ko template: getTemplate() --><!-- /ko -->
@@ -16,6 +16,7 @@
1616
}
1717
}
1818

19+
1920
</script>
2021
</div>
2122

app/code/Magento/Paypal/view/frontend/web/js/view/paylater.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* Copyright © Magento, Inc. All rights reserved.
33
* See COPYING.txt for license details.
44
*/
5-
/* eslint-disable max-nested-callbacks */
5+
66
define([
77
'ko',
88
'uiElement',

dev/tests/integration/testsuite/Magento/Paypal/Block/Bml/PaylaterTest.php renamed to dev/tests/integration/testsuite/Magento/Paypal/Block/PayLater/BannerTest.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,26 +6,26 @@
66

77
declare(strict_types=1);
88

9-
namespace Magento\Paypal\Block\Bml;
9+
namespace Magento\Paypal\Block\Paylater;
1010

1111
use Magento\Framework\View\LayoutInterface;
1212
use Magento\TestFramework\Helper\Bootstrap;
1313

14-
class PaylaterTest extends \PHPUnit\Framework\TestCase
14+
class BannerTest extends \PHPUnit\Framework\TestCase
1515
{
1616
/**
1717
* @magentoAppArea frontend
1818
* @dataProvider getJsLayoutDataProvider
19-
* @covers \Magento\Paypal\Block\Bml\Paylater::getJsLayout()
20-
* @covers \Magento\Paypal\Block\Bml\Paylater::getConfig()
19+
* @covers \Magento\Paypal\Block\PayLater\Banner::getJsLayout()
20+
* @covers \Magento\Paypal\Block\PayLater\Banner::getConfig()
2121
*/
2222
public function testGetJsLayout($layoutConfig, $expectedConfig)
2323
{
2424
/** @var LayoutInterface $layout */
2525
$layout = Bootstrap::getObjectManager()->get(LayoutInterface::class);
2626
$blockConfig['jsLayout']['components']['payLater']['config']['attributes'] = $layoutConfig;
2727
$block = $layout->createBlock(
28-
\Magento\Paypal\Block\Bml\Paylater::class,
28+
\Magento\Paypal\Block\PayLater\Banner::class,
2929
'',
3030
['data' => $blockConfig]
3131
);
@@ -51,14 +51,14 @@ public function getJsLayoutDataProvider()
5151

5252
/**
5353
* @magentoAppArea frontend
54-
* @covers \Magento\Paypal\Block\Bml\Paylater::getJsLayout()
55-
* @covers \Magento\Paypal\Block\Bml\Paylater::getPayPalSdkUrl()
54+
* @covers \Magento\Paypal\Block\PayLater\Banner::getJsLayout()
55+
* @covers \Magento\Paypal\Block\PayLater\Banner::getPayPalSdkUrl()
5656
*/
5757
public function testSdkUrl()
5858
{
5959
$layout = Bootstrap::getObjectManager()->get(LayoutInterface::class);
6060
$block = $layout->createBlock(
61-
\Magento\Paypal\Block\Bml\Paylater::class,
61+
\Magento\Paypal\Block\PayLater\Banner::class,
6262
'',
6363
[]
6464
);
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
11
Magento\LoginAsCustomerAssistance\Block\Adminhtml\NotAllowedPopup
2-
Magento\Paypal\Block\Bml\Paylater

0 commit comments

Comments
 (0)