30349: Product filter with category_id does not work as expected - fixed total_count and items issues

sudheers-kensium · sudheers-kensium · commit 1c1e70e1f96e · 2020-10-08T16:50:34.000+05:30
diff --git a/app/code/Magento/CatalogGraphQl/Model/Resolver/Products/DataProvider/ProductSearch.php b/app/code/Magento/CatalogGraphQl/Model/Resolver/Products/DataProvider/ProductSearch.php
@@ -113,7 +113,7 @@ public function getList(
         $searchResults = $this->searchResultsFactory->create();
         $searchResults->setSearchCriteria($searchCriteriaForCollection);
         $searchResults->setItems($collection->getItems());
-        $searchResults->setTotalCount($searchResult->getTotalCount());
+        $searchResults->setTotalCount($collection->getSize());
         return $searchResults;
     }
 
diff --git a/app/code/Magento/CatalogGraphQl/Model/Resolver/Products/SearchCriteria/CollectionProcessor/FilterProcessor/CategoryFilter.php b/app/code/Magento/CatalogGraphQl/Model/Resolver/Products/SearchCriteria/CollectionProcessor/FilterProcessor/CategoryFilter.php
@@ -61,7 +61,6 @@ public function apply(Filter $filter, AbstractDb $collection)
             $category = $this->categoryFactory->create();
             $this->categoryResourceModel->load($category, $categoryId);
             $categoryProducts[$categoryId] = $category->getProductCollection()->getAllIds();
-            $collection->addCategoryFilter($category);
         }
 
         $categoryProductIds = array_unique(array_merge(...$categoryProducts));

Original file line number	Diff line number	Diff line change
`@@ -113,7 +113,7 @@ public function getList(`
`113`	`113`	`$searchResults = $this->searchResultsFactory->create();`
`114`	`114`	`$searchResults->setSearchCriteria($searchCriteriaForCollection);`
`115`	`115`	`$searchResults->setItems($collection->getItems());`
`116`		`- $searchResults->setTotalCount($searchResult->getTotalCount());`
	`116`	`+ $searchResults->setTotalCount($collection->getSize());`
`117`	`117`	`return $searchResults;`
`118`	`118`	`}`
`119`	`119`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,6 @@ public function apply(Filter $filter, AbstractDb $collection)`
`61`	`61`	`$category = $this->categoryFactory->create();`
`62`	`62`	`$this->categoryResourceModel->load($category, $categoryId);`
`63`	`63`	`$categoryProducts[$categoryId] = $category->getProductCollection()->getAllIds();`
`64`		`- $collection->addCategoryFilter($category);`
`65`	`64`	`}`
`66`	`65`
`67`	`66`	`$categoryProductIds = array_unique(array_merge(...$categoryProducts));`