Skip to content

Commit 1bfa162

Browse files
committed
refactoring and minor fixes
1 parent d1cfc96 commit 1bfa162

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

app/code/Magento/Customer/Test/Mftf/ActionGroup/AdminOpenCustomerGroupEditPageFromGridActionGroup.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@
99
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
1010
<actionGroup name="AdminOpenCustomerGroupEditPageFromGridActionGroup">
1111
<arguments>
12-
<argument name="groupName" type="string"/>
12+
<argument name="groupCode" type="string"/>
1313
</arguments>
1414
<conditionalClick selector="{{AdminCustomerGroupMainSection.selectFirstRow}}" dependentSelector="{{AdminCustomerGroupMainSection.selectFirstRow}}" visible="true" stepKey="clickSelectButton"/>
15-
<click selector="{{AdminCustomerGroupMainSection.editButtonByCustomerGroupCode(groupName)}}" stepKey="clickOnEditCustomerGroup" />
15+
<click selector="{{AdminCustomerGroupMainSection.editButtonByCustomerGroupCode(groupCode)}}" stepKey="clickOnEditCustomerGroup" />
1616
<waitForPageLoad stepKey="waitForCustomerGroupEditPage"/>
1717
</actionGroup>
1818
</actionGroups>

app/code/Magento/Customer/Test/Mftf/Section/AdminEditCustomerGroupSection.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@
99
<sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
1010
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
1111
<section name="AdminEditCustomerGroupSection">
12-
<element name="deleteButton" type="button" selector="#delete"/>
12+
<element name="deleteButton" type="button" selector=".page-actions-buttons button#delete"/>
1313
</section>
1414
</sections>

app/code/Magento/Customer/Test/Mftf/Test/AdminCustomersDeleteSystemCustomerGroupTest.xml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,22 +25,22 @@
2525
<!--Verify Not Logged In customer group-->
2626
<!--Go to Customer Group grid page-->
2727
<actionGroup ref="AdminOpenCustomerGroupsGridPageActionGroup" stepKey="openCustomerGroupGridPageToCheckNotLoggedInGroup"/>
28-
<actionGroup ref="AdminFilterCustomerGroupByNameActionGroup" stepKey="filterCustomerGroupsByNotLoggedInGroupName">
28+
<actionGroup ref="AdminFilterCustomerGroupByNameActionGroup" stepKey="filterCustomerGroupsByNotLoggedInGroup">
2929
<argument name="customerGroupName" value="{{NotLoggedInCustomerGroup.code}}"/>
3030
</actionGroup>
3131
<actionGroup ref="AdminOpenCustomerGroupEditPageFromGridActionGroup" stepKey="openNotLoggedInCustomerGroupEditPage">
32-
<argument name="groupName" value="{{NotLoggedInCustomerGroup.code}}"/>
32+
<argument name="groupCode" value="{{NotLoggedInCustomerGroup.code}}"/>
3333
</actionGroup>
3434
<actionGroup ref="AssertDeleteCustomerGroupButtonMissingActionGroup" stepKey="verifyThereIsNoDeleteButtonForNotLoggedInGroup"/>
3535

3636
<!--Verify General customer group-->
3737
<!--Go to Customer Group grid page-->
3838
<actionGroup ref="AdminOpenCustomerGroupsGridPageActionGroup" stepKey="openCustomerGroupGridPageToCheckGeneralGroup"/>
39-
<actionGroup ref="AdminFilterCustomerGroupByNameActionGroup" stepKey="filterCustomerGroupsByGeneralGroupName">
39+
<actionGroup ref="AdminFilterCustomerGroupByNameActionGroup" stepKey="filterCustomerGroupsByGeneralGroup">
4040
<argument name="customerGroupName" value="{{GeneralCustomerGroup.code}}"/>
4141
</actionGroup>
4242
<actionGroup ref="AdminOpenCustomerGroupEditPageFromGridActionGroup" stepKey="openGeneralCustomerGroupEditPage">
43-
<argument name="groupName" value="{{GeneralCustomerGroup.code}}"/>
43+
<argument name="groupCode" value="{{GeneralCustomerGroup.code}}"/>
4444
</actionGroup>
4545
<actionGroup ref="AssertDeleteCustomerGroupButtonMissingActionGroup" stepKey="verifyThereIsNoDeleteButtonForGeneralGroup"/>
4646
</test>

0 commit comments

Comments
 (0)