Skip to content

Commit 1be7a79

Browse files
committed
Merge branch 'B2B-2113' of https://github.com/magento-arcticfoxes/magento2ce into af-prs-develop
2 parents a37c626 + 437ddfa commit 1be7a79

File tree

4 files changed

+14
-1
lines changed

4 files changed

+14
-1
lines changed

app/code/Magento/Catalog/Test/Mftf/ActionGroup/AddProductImageActionGroup.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,12 @@
1616
<argument name="image" defaultValue="ProductImage"/>
1717
</arguments>
1818

19+
<waitForElementVisible selector="{{AdminProductImagesSection.productImagesToggle}}" stepKey="waitForImagesSection"/>
1920
<conditionalClick selector="{{AdminProductImagesSection.productImagesToggle}}" dependentSelector="{{AdminProductImagesSection.imageUploadButton}}" visible="false" stepKey="openProductImagesSection"/>
20-
<waitForPageLoad time="30" stepKey="waitForPageRefresh"/>
21+
<waitForPageLoad stepKey="waitForPageRefresh"/>
2122
<waitForElementVisible selector="{{AdminProductImagesSection.imageUploadButton}}" stepKey="seeImageSectionIsReady"/>
2223
<attachFile selector="{{AdminProductImagesSection.imageFileUpload}}" userInput="{{image.file}}" stepKey="uploadFile"/>
24+
<waitForPageLoad stepKey="waitForImageUpload"/>
2325
<waitForElementNotVisible selector="{{AdminProductImagesSection.uploadProgressBar}}" stepKey="waitForUpload"/>
2426
<waitForElementVisible selector="{{AdminProductImagesSection.imageFile(image.fileName)}}" stepKey="waitForThumbnail"/>
2527
</actionGroup>

app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminAssertProductImageOnProductPageActionGroup.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
<arguments>
1616
<argument name="image" defaultValue="{{MagentoLogo.filename}}" type="string"/>
1717
</arguments>
18+
<waitForElementVisible selector="{{AdminProductImagesSection.productImagesToggle}}" stepKey="waitForProductImagesSection"/>
1819
<conditionalClick selector="{{AdminProductImagesSection.productImagesToggle}}" dependentSelector="{{AdminProductImagesSection.imageUploadButton}}" visible="false" stepKey="openProductImagesSection"/>
1920
<waitForPageLoad stepKey="waitForPageLoad"/>
2021
<waitForElementVisible selector="{{AdminProductImagesSection.imageFile(image)}}" stepKey="seeImage"/>

app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductAssertImageAltTextActionGroup.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,20 @@
1616
<argument name="image" defaultValue="ProductImage"/>
1717
<argument name="altText" defaultValue="{{ProductImage.title}}" type="string"/>
1818
</arguments>
19+
<waitForElementVisible selector="{{AdminProductImagesSection.productImagesToggle}}" stepKey="waitForImagesSection"/>
1920
<conditionalClick selector="{{AdminProductImagesSection.productImagesToggle}}" dependentSelector="{{AdminProductImagesSection.imageFile(image.fileName)}}" visible="false" stepKey="expandImages"/>
21+
<waitForPageLoad stepKey="waitForImages"/>
2022
<waitForElementVisible selector="{{AdminProductImagesSection.imageFile(image.fileName)}}" stepKey="seeProductImageName"/>
2123
<click selector="{{AdminProductImagesSection.imageFile(image.fileName)}}" stepKey="clickProductImage"/>
24+
<waitForPageLoad stepKey="waitForImageDetails"/>
2225
<waitForElementVisible selector="{{AdminProductImagesSection.altText}}" stepKey="seeAltTextSection"/>
2326
<grabValueFrom selector="{{AdminProductImagesSection.altText}}" stepKey="actualAltText"/>
2427
<assertEquals stepKey="assertAltText">
2528
<expectedResult type="string">{{altText}}</expectedResult>
2629
<actualResult type="variable">actualAltText</actualResult>
2730
</assertEquals>
2831
<click selector="{{AdminSlideOutDialogSection.closeButton}}" stepKey="clickCloseButton"/>
32+
<waitForPageLoad stepKey="waitForClose"/>
33+
<waitForElementNotVisible selector="{{AdminProductImagesSection.altText}}" stepKey="waitForDetailsGone"/>
2934
</actionGroup>
3035
</actionGroups>

app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminProductChangeImageAltTextActionGroup.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,16 @@
1616
<argument name="image" defaultValue="ProductImage"/>
1717
<argument name="altText" defaultValue="{{ProductImage.title}}" type="string"/>
1818
</arguments>
19+
<waitForElementVisible selector="{{AdminProductImagesSection.productImagesToggle}}" stepKey="waitForImagesSection"/>
1920
<conditionalClick selector="{{AdminProductImagesSection.productImagesToggle}}" dependentSelector="{{AdminProductImagesSection.imageFile(image.fileName)}}" visible="false" stepKey="expandImages"/>
21+
<waitForPageLoad stepKey="waitForImages"/>
2022
<waitForElementVisible selector="{{AdminProductImagesSection.imageFile(image.fileName)}}" stepKey="seeProductImageName"/>
2123
<click selector="{{AdminProductImagesSection.imageFile(image.fileName)}}" stepKey="clickProductImage"/>
24+
<waitForPageLoad stepKey="waitForImageDetails"/>
2225
<waitForElementVisible selector="{{AdminProductImagesSection.altText}}" stepKey="seeAltTextSection"/>
2326
<fillField selector="{{AdminProductImagesSection.altText}}" userInput="{{altText}}" stepKey="fillAltTextSection"/>
2427
<click selector="{{AdminSlideOutDialogSection.closeButton}}" stepKey="clickCloseButton"/>
28+
<waitForPageLoad stepKey="waitForClose"/>
29+
<waitForElementNotVisible selector="{{AdminProductImagesSection.altText}}" stepKey="waitForDetailsGone"/>
2530
</actionGroup>
2631
</actionGroups>

0 commit comments

Comments
 (0)