Skip to content

Commit 1bb9a79

Browse files
MC-30391: Category not considered Configurable product in cart rule
1 parent 8ee3d16 commit 1bb9a79

File tree

1 file changed

+2
-49
lines changed
  • dev/tests/integration/testsuite/Magento/SalesRule/Model/Rule/Condition

1 file changed

+2
-49
lines changed

dev/tests/integration/testsuite/Magento/SalesRule/Model/Rule/Condition/ProductTest.php

Lines changed: 2 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,6 @@
66

77
namespace Magento\SalesRule\Model\Rule\Condition;
88

9-
use Magento\Quote\Api\CartRepositoryInterface;
10-
use Magento\Framework\Api\SearchCriteriaBuilder;
11-
use Magento\Quote\Api\Data\CartInterface;
12-
use Magento\SalesRule\Api\RuleRepositoryInterface;
139
use Magento\Framework\Registry;
1410
use Magento\SalesRule\Model\Rule;
1511

@@ -18,6 +14,8 @@
1814
*/
1915
class ProductTest extends \PHPUnit\Framework\TestCase
2016
{
17+
use ConditionHelper;
18+
2119
/**
2220
* @var \Magento\Framework\ObjectManagerInterface
2321
*/
@@ -133,51 +131,6 @@ public function testValidateQtySalesRuleWithConfigurable()
133131
);
134132
}
135133

136-
/**
137-
* Gets quote by reserved order id.
138-
*
139-
* @param string $reservedOrderId
140-
* @return CartInterface
141-
*/
142-
private function getQuote($reservedOrderId)
143-
{
144-
/** @var SearchCriteriaBuilder $searchCriteriaBuilder */
145-
$searchCriteriaBuilder = $this->objectManager->get(SearchCriteriaBuilder::class);
146-
$searchCriteria = $searchCriteriaBuilder->addFilter('reserved_order_id', $reservedOrderId)
147-
->create();
148-
149-
/** @var CartRepositoryInterface $quoteRepository */
150-
$quoteRepository = $this->objectManager->get(CartRepositoryInterface::class);
151-
$items = $quoteRepository->getList($searchCriteria)->getItems();
152-
return array_pop($items);
153-
}
154-
155-
/**
156-
* Gets rule by name.
157-
*
158-
* @param string $name
159-
* @return \Magento\SalesRule\Model\Rule
160-
* @throws \Magento\Framework\Exception\InputException
161-
* @throws \Magento\Framework\Exception\NoSuchEntityException
162-
*/
163-
private function getSalesRule(string $name): \Magento\SalesRule\Model\Rule
164-
{
165-
/** @var SearchCriteriaBuilder $searchCriteriaBuilder */
166-
$searchCriteriaBuilder = $this->objectManager->get(SearchCriteriaBuilder::class);
167-
$searchCriteria = $searchCriteriaBuilder->addFilter('name', $name)
168-
->create();
169-
170-
/** @var CartRepositoryInterface $quoteRepository */
171-
$ruleRepository = $this->objectManager->get(RuleRepositoryInterface::class);
172-
$items = $ruleRepository->getList($searchCriteria)->getItems();
173-
174-
$rule = array_pop($items);
175-
/** @var \Magento\SalesRule\Model\Converter\ToModel $converter */
176-
$converter = $this->objectManager->get(\Magento\SalesRule\Model\Converter\ToModel::class);
177-
178-
return $converter->toModel($rule);
179-
}
180-
181134
/**
182135
* Ensure that SalesRules filtering on quote items quantity validates configurable product parent category correctly
183136
*

0 commit comments

Comments
 (0)