Merge pull request #1496 from magento-engcom/develop-prs

[EngCom] Public Pull Requests
 - MAGETWO-75310 Fixed Typo Mistake in comment. #10905
 - MAGETWO-75309 Add escaping of js translation version #10904
 - MAGETWO-72341 enable universal use of modal and tab_group #10789

Author: ishakhsuvarov

app/code/Magento/ConfigurableProduct/Model/Product/Type/Configurable/Attribute.php

@@ -111,7 +111,7 @@ public function afterSave()
     }
 
     /**
-     * Load counfigurable attribute by product and product's attribute
+     * Load configurable attribute by product and product's attribute
      *
      * @param \Magento\Catalog\Model\Product $product
      * @param \Magento\Catalog\Model\ResourceModel\Eav\Attribute  $attribute

app/code/Magento/Translation/view/base/templates/translate.phtml

@@ -28,7 +28,7 @@
 
                 <?php $version = $block->getTranslationFileVersion(); ?>
 
-                if (versionObj.version !== '<?= /* @noEscape */ $version ?>') {
+                if (versionObj.version !== '<?php $block->escapeJsQuote($version) ?>') {
                     dependencies.push(
                         'text!<?= /* @noEscape */ Magento\Translation\Model\Js\Config::DICTIONARY_FILE_NAME ?>'
                     );
@@ -44,7 +44,7 @@
                             $.localStorage.set(
                                 'mage-translation-file-version',
                                 {
-                                    version: '<?= /* @noEscape */ $version ?>'
+                                    version: '<?php $block->escapeJsQuote($version) ?>'
                                 }
                             );
                         } else {

app/code/Magento/Ui/view/base/web/js/form/components/tab_group.js

@@ -65,7 +65,7 @@ define([
                 invalid;
 
             invalid = _.find(result, function (item) {
-                return !item.valid;
+                return typeof item !== 'undefined' && !item.valid;
             });
 
             if (invalid) {

app/code/Magento/Ui/view/base/web/js/modal/modal-component.js

@@ -229,6 +229,10 @@ define([
          * Validate everything validatable in modal
          */
         validate: function (elem) {
+            if (typeof elem === 'undefined') {
+                return;
+            }
+
             if (typeof elem.validate === 'function') {
                 this.valid = this.valid & elem.validate().valid;
             } else if (elem.elems) {