ENGCOM-7958: #1714: Change access level for metadata model functions to private #29401

slavvka · web-flow · commit 1b3d39667c51 · 2020-08-05T12:55:14.000-05:00
diff --git a/app/code/Magento/MediaGalleryMetadata/Model/Jpeg/ReadFile.php b/app/code/Magento/MediaGalleryMetadata/Model/Jpeg/ReadFile.php
@@ -76,7 +76,7 @@ public function __construct(
      * @return bool
      * @throws FileSystemException
      */
-    public function isApplicable(string $path): bool
+    private function isApplicable(string $path): bool
     {
         $resource = $this->driver->fileOpen($path, 'rb');
         try {
diff --git a/app/code/Magento/MediaGalleryMetadata/Model/Png/Segment/WriteXmp.php b/app/code/Magento/MediaGalleryMetadata/Model/Png/Segment/WriteXmp.php
@@ -114,7 +114,7 @@ private function insertPngXmpSegment(array $segments, SegmentInterface $xmpSegme
      * @param MetadataInterface $metadata
      * @return SegmentInterface
      */
-    public function createPngXmpSegment(MetadataInterface $metadata): SegmentInterface
+    private function createPngXmpSegment(MetadataInterface $metadata): SegmentInterface
     {
         $xmpData = $this->xmpTemplate->get();
         return $this->segmentFactory->create([

Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ public function __construct(`
`76`	`76`	`* @return bool`
`77`	`77`	`* @throws FileSystemException`
`78`	`78`	`*/`
`79`		`- public function isApplicable(string $path): bool`
	`79`	`+ private function isApplicable(string $path): bool`
`80`	`80`	`{`
`81`	`81`	`$resource = $this->driver->fileOpen($path, 'rb');`
`82`	`82`	`try {`
Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ private function insertPngXmpSegment(array $segments, SegmentInterface $xmpSegme`
`114`	`114`	`* @param MetadataInterface $metadata`
`115`	`115`	`* @return SegmentInterface`
`116`	`116`	`*/`
`117`		`- public function createPngXmpSegment(MetadataInterface $metadata): SegmentInterface`
	`117`	`+ private function createPngXmpSegment(MetadataInterface $metadata): SegmentInterface`
`118`	`118`	`{`
`119`	`119`	`$xmpData = $this->xmpTemplate->get();`
`120`	`120`	`return $this->segmentFactory->create([`