Skip to content

Commit 1a66bfa

Browse files
committed
Merge branch 'MAGETWO-63243' into 2.0-pr10
2 parents 0219ace + 003b6b1 commit 1a66bfa

File tree

3 files changed

+41
-7
lines changed

3 files changed

+41
-7
lines changed

dev/tests/static/testsuite/Magento/Test/Legacy/CopyrightTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public function testCopyright()
1717
$invoker(
1818
function ($filename) {
1919
$fileText = file_get_contents($filename);
20-
if (strpos($fileText, 'Copyright © ' . date('Y')) === false) {
20+
if (strpos($fileText, 'Copyright © 2016') === false) {
2121
$this->fail('Copyright is missing or has wrong year in ' . $filename);
2222
}
2323
},

setup/src/Magento/Setup/Model/UninstallDependencyCheck.php

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,13 @@
1515
*/
1616
class UninstallDependencyCheck
1717
{
18+
/**
19+
* Need to exclude these packages from dependencies because of changes in composer/composer package
20+
* It consider now that all packages are depends on root package
21+
* @var array
22+
*/
23+
private $rootDependencies = ['magento/magento2ce', 'magento/magento2ee'];
24+
1825
/**
1926
* @var ComposerInformation
2027
*/
@@ -61,6 +68,7 @@ public function runUninstallReadinessCheck(array $packages)
6168
try {
6269
$packagesAndTypes = $this->composerInfo->getRootRequiredPackageTypesByName();
6370
$dependencies = $this->packageDependencyChecker->checkDependencies($packages, true);
71+
$dependencies = $this->excludeRootDependencies($dependencies);
6472
$messages = [];
6573
$themes = [];
6674

@@ -101,4 +109,20 @@ public function runUninstallReadinessCheck(array $packages)
101109
return ['success' => false, 'error' => $message];
102110
}
103111
}
112+
113+
/**
114+
* Exclude root dependencies like 'magento/magento2ce' or 'magento/magento2ee'
115+
*
116+
* @param array $dependencies
117+
* @return array
118+
*/
119+
private function excludeRootDependencies($dependencies)
120+
{
121+
$result = [];
122+
foreach ($dependencies as $packageName => $packageDependencies) {
123+
$result[$packageName] = array_values(array_diff($packageDependencies, $this->rootDependencies));
124+
}
125+
126+
return $result;
127+
}
104128
}

setup/src/Magento/Setup/Test/Unit/Model/UninstallDependencyCheckTest.php

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,23 +37,23 @@ class UninstallDependencyCheckTest extends \PHPUnit_Framework_TestCase
3737

3838
public function setup()
3939
{
40-
$this->composerInfo = $this->getMock('Magento\Framework\Composer\ComposerInformation', [], [], '', false);
40+
$this->composerInfo = $this->getMock(\Magento\Framework\Composer\ComposerInformation::class, [], [], '', false);
4141
$this->packageDependencyChecker = $this->getMock(
42-
'Magento\Framework\Composer\DependencyChecker',
42+
\Magento\Framework\Composer\DependencyChecker::class,
4343
[],
4444
[],
4545
'',
4646
false
4747
);
4848
$this->themeDependencyChecker = $this->getMock(
49-
'Magento\Theme\Model\Theme\ThemeDependencyChecker',
49+
\Magento\Theme\Model\Theme\ThemeDependencyChecker::class,
5050
[],
5151
[],
5252
'',
5353
false
5454
);
5555
$this->themeDependencyCheckerFactory = $this->getMock(
56-
'Magento\Setup\Model\ThemeDependencyCheckerFactory',
56+
\Magento\Setup\Model\ThemeDependencyCheckerFactory::class,
5757
[],
5858
[],
5959
'',
@@ -81,7 +81,12 @@ public function testRunUninstallReadinessCheck()
8181
$this->packageDependencyChecker->expects($this->once())
8282
->method('checkDependencies')
8383
->with(array_keys($packages))
84-
->willReturn([]);
84+
->willReturn([
85+
'verndor/module' => ['magento/magento2ce'],
86+
'verndor/theme' => ['magento/magento2ee'],
87+
'verndor/metapackage' => ['magento/magento2ce'],
88+
'verndor/language' => ['magento/magento2ce'],
89+
]);
8590

8691
$this->themeDependencyChecker->expects($this->once())
8792
->method('checkChildThemeByPackagesName')
@@ -105,7 +110,12 @@ public function testRunUninstallReadinessCheckWithError()
105110
$this->packageDependencyChecker->expects($this->once())
106111
->method('checkDependencies')
107112
->with(array_keys($packages))
108-
->willReturn([]);
113+
->willReturn([
114+
'verndor/module' => ['magento/magento2ce'],
115+
'verndor/theme' => ['magento/magento2ee'],
116+
'verndor/metapackage' => ['magento/magento2ce'],
117+
'verndor/language' => ['magento/magento2ce'],
118+
]);
109119

110120
$this->themeDependencyChecker->expects($this->once())
111121
->method('checkChildThemeByPackagesName')

0 commit comments

Comments
 (0)