Skip to content

Commit 19ddf65

Browse files
author
Oleksandr Gorkun
committed
MAGETWO-92197: [Backport for 2.2.x] Mass Action Wrong Requests
1 parent 8dfaa62 commit 19ddf65

File tree

3 files changed

+48
-0
lines changed

3 files changed

+48
-0
lines changed

app/code/Magento/Sales/Controller/Adminhtml/Order/MassCancel.php

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,12 @@
55
*/
66
namespace Magento\Sales\Controller\Adminhtml\Order;
77

8+
use Magento\Framework\Exception\NotFoundException;
89
use Magento\Framework\Model\ResourceModel\Db\Collection\AbstractCollection;
910
use Magento\Backend\App\Action\Context;
1011
use Magento\Ui\Component\MassAction\Filter;
1112
use Magento\Sales\Model\ResourceModel\Order\CollectionFactory;
13+
use Magento\Framework\App\Request\Http as HttpRequest;
1214

1315
class MassCancel extends \Magento\Sales\Controller\Adminhtml\Order\AbstractMassAction
1416
{
@@ -28,6 +30,20 @@ public function __construct(Context $context, Filter $filter, CollectionFactory
2830
$this->collectionFactory = $collectionFactory;
2931
}
3032

33+
/**
34+
* @inheritDoc
35+
*/
36+
public function execute()
37+
{
38+
/** @var HttpRequest $request */
39+
$request = $this->getRequest();
40+
if (!$request->isPost()) {
41+
throw new NotFoundException(__('Page not found.'));
42+
}
43+
44+
return parent::execute();
45+
}
46+
3147
/**
3248
* Cancel selected orders
3349
*

app/code/Magento/Sales/Controller/Adminhtml/Order/MassHold.php

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,13 @@
55
*/
66
namespace Magento\Sales\Controller\Adminhtml\Order;
77

8+
use Magento\Framework\Exception\NotFoundException;
89
use Magento\Framework\Model\ResourceModel\Db\Collection\AbstractCollection;
910
use Magento\Backend\App\Action\Context;
1011
use Magento\Ui\Component\MassAction\Filter;
1112
use Magento\Sales\Model\ResourceModel\Order\CollectionFactory;
1213
use Magento\Sales\Api\OrderManagementInterface;
14+
use Magento\Framework\App\Request\Http as HttpRequest;
1315

1416
/**
1517
* Class MassHold
@@ -43,6 +45,20 @@ public function __construct(
4345
$this->orderManagement = $orderManagement;
4446
}
4547

48+
/**
49+
* @inheritDoc
50+
*/
51+
public function execute()
52+
{
53+
/** @var HttpRequest $request */
54+
$request = $this->getRequest();
55+
if (!$request->isPost()) {
56+
throw new NotFoundException(__('Page not found.'));
57+
}
58+
59+
return parent::execute();
60+
}
61+
4662
/**
4763
* Hold selected orders
4864
*

app/code/Magento/Sales/Controller/Adminhtml/Order/MassUnhold.php

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,13 @@
55
*/
66
namespace Magento\Sales\Controller\Adminhtml\Order;
77

8+
use Magento\Framework\Exception\NotFoundException;
89
use Magento\Framework\Model\ResourceModel\Db\Collection\AbstractCollection;
910
use Magento\Backend\App\Action\Context;
1011
use Magento\Ui\Component\MassAction\Filter;
1112
use Magento\Sales\Model\ResourceModel\Order\CollectionFactory;
1213
use Magento\Sales\Api\OrderManagementInterface;
14+
use Magento\Framework\App\Request\Http as HttpRequest;
1315

1416
class MassUnhold extends AbstractMassAction
1517
{
@@ -42,6 +44,20 @@ public function __construct(
4244
);
4345
}
4446

47+
/**
48+
* @inheritDoc
49+
*/
50+
public function execute()
51+
{
52+
/** @var HttpRequest $request */
53+
$request = $this->getRequest();
54+
if (!$request->isPost()) {
55+
throw new NotFoundException(__('Page not found.'));
56+
}
57+
58+
return parent::execute();
59+
}
60+
4561
/**
4662
* Unhold selected orders
4763
*

0 commit comments

Comments
 (0)