Skip to content

Commit 1991904

Browse files
author
Bibu Mathew
committed
Merge remote-tracking branch 'origin/MAGETWO-31776-add-parent-element-theme' into MAGETWO-31776-add-parent-element-theme
2 parents e2e8519 + 8bb3db5 commit 1991904

File tree

13 files changed

+24
-113
lines changed

13 files changed

+24
-113
lines changed

app/code/Magento/Core/Model/Theme/Collection.php

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -268,15 +268,7 @@ protected function _getConfigModel($configPath)
268268
$relativeConfigPath = $this->_directory->getRelativePath($configPath);
269269
$configContent = $this->_directory->isExist($relativeConfigPath) ?
270270
$this->_directory->readFile($relativeConfigPath) : null;
271-
$relativeComposerPath = dirname($relativeConfigPath) . '/composer.json';
272-
$composerContent = $this->_directory->isExist($relativeComposerPath) ?
273-
$this->_directory->readFile($relativeComposerPath) : null;
274-
return $this->themeConfigFactory->create(
275-
[
276-
'configContent' => $configContent,
277-
'composerContent' => $composerContent,
278-
]
279-
);
271+
return $this->themeConfigFactory->create(['configContent' => $configContent]);
280272
}
281273

282274
/**

dev/tests/unit/testsuite/Magento/Framework/Config/ThemeTest.php

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,7 @@ public function testDataGetter($themePath, $expected)
5959
$config = $this->objectManager->getObject(
6060
'Magento\Framework\Config\Theme',
6161
[
62-
'configContent' => file_get_contents(__DIR__ . '/_files/area/' . $themePath . '/theme.xml'),
63-
'composerContent' => file_get_contents(__DIR__ . '/_files/area/' . $themePath . '/composer.json'),
62+
'configContent' => file_get_contents(__DIR__ . '/_files/area/' . $themePath . '/theme.xml')
6463
]
6564
);
6665
$this->assertSame($expected['version'], $config->getThemeVersion());
@@ -89,15 +88,15 @@ public function dataGetterDataProvider()
8988
'version' => '0.1.1',
9089
'media' => ['preview_image' => ''],
9190
'title' => 'Test',
92-
'parent' => ['Magento', 'default_default'],
91+
'parent' => ['default_default'],
9392
]]],
9493
[
9594
'default_test2',
9695
[[
9796
'version' => '0.1.2',
9897
'media' => ['preview_image' => ''],
9998
'title' => 'Test2',
100-
'parent' => ['Magento', 'default_test'],
99+
'parent' => ['default_test'],
101100
]]],
102101
[
103102
'test_default',
@@ -113,7 +112,7 @@ public function dataGetterDataProvider()
113112
'version' => '0.1.4',
114113
'media' => ['preview_image' => ''],
115114
'title' => 'Default',
116-
'parent' => ['Magento', 'default_test2'],
115+
'parent' => ['default_test2'],
117116
]]],
118117
];
119118
}

dev/tests/unit/testsuite/Magento/Framework/Config/_files/area/default_default/composer.json

Lines changed: 0 additions & 11 deletions
This file was deleted.

dev/tests/unit/testsuite/Magento/Framework/Config/_files/area/default_default/theme.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
-->
77
<theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../../../../../lib/internal/Magento/Framework/Config/etc/theme.xsd">
88
<title>Default</title>
9+
<version>0.1.0</version>
910
<media>
1011
<preview_image>media/default_default.jpg</preview_image>
1112
</media>

dev/tests/unit/testsuite/Magento/Framework/Config/_files/area/default_test/composer.json

Lines changed: 0 additions & 12 deletions
This file was deleted.

dev/tests/unit/testsuite/Magento/Framework/Config/_files/area/default_test/theme.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
-->
77
<theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../../../../../lib/internal/Magento/Framework/Config/etc/theme.xsd">
88
<title>Test</title>
9+
<version>0.1.1</version>
10+
<parent>default_default</parent>
911
<media>
1012
<preview_image />
1113
</media>

dev/tests/unit/testsuite/Magento/Framework/Config/_files/area/default_test2/composer.json

Lines changed: 0 additions & 12 deletions
This file was deleted.

dev/tests/unit/testsuite/Magento/Framework/Config/_files/area/default_test2/theme.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,6 @@
66
-->
77
<theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../../../../../lib/internal/Magento/Framework/Config/etc/theme.xsd">
88
<title>Test2</title>
9+
<version>0.1.2</version>
10+
<parent>default_test</parent>
911
</theme>

dev/tests/unit/testsuite/Magento/Framework/Config/_files/area/test_default/composer.json

Lines changed: 0 additions & 11 deletions
This file was deleted.

dev/tests/unit/testsuite/Magento/Framework/Config/_files/area/test_default/theme.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
-->
77
<theme xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../../../../../lib/internal/Magento/Framework/Config/etc/theme.xsd">
88
<title>Default</title>
9+
<version>0.1.3</version>
910
<media>
1011
<preview_image>media/test_default.jpg</preview_image>
1112
</media>

0 commit comments

Comments
 (0)