ACP2E-2247: [Cloud] Misleading prompts on Additional Settings section when setting up a Tax Rule:

AnujNehra · AnujNehra · commit 196405ccbe78 · 2023-09-01T23:51:48.000+05:30
diff --git a/app/code/Magento/Tax/Test/Mftf/Test/AdminCheckTaxForDetailsTagExpandCollapseTest.xml b/app/code/Magento/Tax/Test/Mftf/Test/AdminCheckTaxForDetailsTagExpandCollapseTest.xml
@@ -16,6 +16,7 @@
             <description value="Checking expand and collapse icon for additional settings"/>
             <severity value="AVERAGE"/>
             <testCaseId value="AC-9376"/>
+            <useCaseId value="ACP2E-2247"/>
             <group value="tax"/>
             <group value="sales"/>
         </annotations>
diff --git a/app/code/Magento/Tax/view/adminhtml/layout/tax_rule_edit.xml b/app/code/Magento/Tax/view/adminhtml/layout/tax_rule_edit.xml
@@ -9,7 +9,6 @@
     <head>
         <link src="Magento_Tax::js/bootstrap.js"/>
         <css src="jquery/editableMultiselect/css/jquery.multiselect.css"/>
-        <css src="Magento_Tax::css/tax.css"/>
     </head>
     <body>
         <referenceContainer name="content">
diff --git a/app/code/Magento/Tax/view/adminhtml/templates/rule/edit.phtml b/app/code/Magento/Tax/view/adminhtml/templates/rule/edit.phtml
@@ -318,8 +318,7 @@ $scriptString.= <<<script
 
     window.TaxRateEditableMultiselect = TaxRateEditableMultiselect;
 });
-script;
-$scriptString.= <<<script
+
 require(['jquery'], function($) {
       jQuery('.admin__collapsible-block-wrapper').on('click', function () {
             if(!this.hasAttribute('open')) {
diff --git a/app/code/Magento/Tax/view/adminhtml/web/css/tax.css b/app/code/Magento/Tax/view/adminhtml/web/css/tax.css
diff --git a/app/design/adminhtml/Magento/backend/Magento_Tax/web/css/source/_module.less b/app/design/adminhtml/Magento/backend/Magento_Tax/web/css/source/_module.less
@@ -25,3 +25,11 @@
         font-size: 1.3rem;
     }
 }
+
+.admin__collapsible-block-wrapper.__show .admin__collapsible-title.__show:before {
+    content: @icon-expand-close__content;
+    font-size: @collapsible-title-icon__size;
+    position: absolute;
+    right: @data-grid__font-size;
+    top: 2.3rem;
+}

Original file line number	Diff line number	Diff line change
`@@ -25,3 +25,11 @@`
`25`	`25`	`font-size: 1.3rem;`
`26`	`26`	`}`
`27`	`27`	`}`
	`28`	`+`
	`29`	`+.admin__collapsible-block-wrapper.__show .admin__collapsible-title.__show:before {`
	`30`	`+ content: @icon-expand-close__content;`
	`31`	`+ font-size: @collapsible-title-icon__size;`
	`32`	`+ position: absolute;`
	`33`	`+ right: @data-grid__font-size;`
	`34`	`+ top: 2.3rem;`
	`35`	`+}`