Skip to content

Commit 18d31db

Browse files
MAGETWO-72085: Allow browser back/forward button to shipping step #10698
1 parent d7308bf commit 18d31db

File tree

3 files changed

+14
-4
lines changed

3 files changed

+14
-4
lines changed

app/code/Magento/Checkout/view/frontend/web/js/model/step-navigator.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ define([
4747

4848
steps.sort(this.sortItems).forEach(function (element) {
4949
if (element.code == hashString || element.alias == hashString) { //eslint-disable-line eqeqeq
50-
element.navigate();
50+
element.navigate(element);
5151
} else {
5252
element.isVisible(false);
5353
}

app/code/Magento/Checkout/view/frontend/web/js/view/shipping.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,13 @@ define([
126126
return this;
127127
},
128128

129-
navigate: function () {
130-
this.isVisible(true);
129+
/**
130+
* Navigator change hash handler.
131+
*
132+
* @param {Object} step - navigation step
133+
*/
134+
navigate: function (step) {
135+
step && step.isVisible(true);
131136
},
132137

133138
/**

dev/tests/js/jasmine/tests/app/code/Magento/Checkout/frontend/js/view/shipping.test.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,12 @@ define(['squire', 'ko', 'jquery', 'jquery/validate'], function (Squire, ko, $) {
8080
describe('Magento_Checkout/js/view/shipping', function () {
8181
describe('"navigate" method', function () {
8282
it('Check for return value.', function () {
83-
expect(obj.navigate()).toBeUndefined();
83+
var step = {
84+
isVisible: ko.observable(false)
85+
};
86+
87+
expect(obj.navigate(step)).toBeUndefined();
88+
expect(step.isVisible()).toBe(true);
8489
});
8590
});
8691

0 commit comments

Comments
 (0)