MAGETWO-61240: Fix \Magento\Sniffs\Translation\ConstantUsageSniff

Addressing code review feedback

Author: Igor Melnikov

dev/tests/static/framework/tests/unit/testsuite/Magento/Sniffs/Translation/_files/correct_arguments.txt

@@ -4,26 +4,26 @@
  * See COPYING.txt for license details.
  */
 
-$item[ConfigConverter::KEY_TITLE] = __($item)
+__($variable)
 
-$item[ConfigConverter::KEY_TITLE] = __($item[Converter::KEY_TITLE])
+__($variable[Class::CONSTANT])
 
-$item[ConfigConverter::KEY_TITLE] = __($item['\Magento\Support\Model\Report\Config\Converter::KEY_TITLE'])
+__($variable[\Namespace\Class::CONSTANT])
 
-$item[ConfigConverter::KEY_TITLE] = __($item['value'])
+__($variable['value'])
 
-$item[ConfigConverter::KEY_TITLE] = __(
-    $item
+__(
+    $variable
 )
 
-Phrase($item)
+Phrase($variable)
 
-Phrase($item[Converter::KEY_TITLE])
+Phrase($variable[Class::CONSTANT])
 
-Phrase($item['\Magento\Support\Model\Report\Config\Converter::KEY_TITLE'])
+Phrase($variable[\Namespace\Class::CONSTANT])
 
-\Magento\Framework\Phrase($item['value'])
+\Magento\Framework\Phrase($variable['value'])
 
 \Magento\Framework\Phrase(
-    $item[Converter::KEY_TITLE]
+    $variable[Class::CONSTANT]
 )

dev/tests/static/framework/tests/unit/testsuite/Magento/Sniffs/Translation/_files/incorrect_arguments.txt

@@ -4,24 +4,24 @@
  * See COPYING.txt for license details.
  */
 
-$item[ConfigConverter::KEY_TITLE] = __(Converter::KEY_TITLE)
+__(Class::CONSTANT)
 
-$item[ConfigConverter::KEY_TITLE] = __(self::KEY_TITLE)
+__(self::CONSTANT)
 
-$item[ConfigConverter::KEY_TITLE] = __(\Magento\Support\Model\Report\Config\Converter::KEY_TITLE)
+__(\Namespace\Class::CONSTANT)
 
-$item[ConfigConverter::KEY_TITLE] = __(
-    Converter::KEY_TITLE
+__(
+    Class::CONSTANT
 )
 
-Phrase(Converter::KEY_TITLE)
+Phrase(Class::CONSTANT)
 
-Phrase(self::KEY_TITLE)
+Phrase(self::CONSTANT)
 
-Phrase(\Magento\Support\Model\Report\Config\Converter::KEY_TITLE)
+Phrase(\Namespace\Class::CONSTANT)
 
-\Magento\Framework\Phrase(Converter::KEY_TITLE)
+\Magento\Framework\Phrase(Class::CONSTANT)
 
 \Magento\Framework\Phrase(
-    Converter::KEY_TITLE
+    Class::CONSTANT
 )