Skip to content

Commit 181d3da

Browse files
author
ogorkun
committed
MC-32830: Do not store admin and customer tokens in DB
1 parent a6b6578 commit 181d3da

File tree

2 files changed

+33
-20
lines changed

2 files changed

+33
-20
lines changed

app/code/Magento/Integration/Plugin/Model/AdminUser.php

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
namespace Magento\Integration\Plugin\Model;
88

99
use Magento\Integration\Model\AdminTokenService;
10+
use Magento\User\Model\User;
11+
use Magento\Framework\Model\AbstractModel;
1012

1113
/**
1214
* Plugin to delete admin tokens when admin becomes inactive
@@ -27,22 +29,22 @@ public function __construct(
2729
$this->adminTokenService = $adminTokenService;
2830
}
2931

30-
/**
31-
* Check if admin is inactive - if so, invalidate their tokens
32-
*
33-
* @param \Magento\User\Model\User $subject
34-
* @param \Magento\Framework\DataObject $object
35-
* @return \Magento\User\Model\User
36-
* @throws \Magento\Framework\Exception\LocalizedException
37-
*/
3832
public function afterSave(
39-
\Magento\User\Model\User $subject,
40-
\Magento\Framework\DataObject $object
41-
): \Magento\User\Model\User {
42-
$isActive = $object->getIsActive();
33+
User $subject,
34+
AbstractModel $return
35+
): AbstractModel {
36+
$isActive = $return->getIsActive();
4337
if ($isActive !== null && $isActive == 0) {
44-
$this->adminTokenService->revokeAdminAccessToken($object->getId());
38+
$this->adminTokenService->revokeAdminAccessToken((int) $return->getId());
4539
}
46-
return $subject;
40+
41+
return $return;
42+
}
43+
44+
public function afterDelete(User $subject, AbstractModel $return): AbstractModel
45+
{
46+
$this->adminTokenService->revokeAdminAccessToken((int) $return->getId());
47+
48+
return $return;
4749
}
4850
}

app/code/Magento/Integration/Plugin/Model/CustomerUser.php

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@
55
*/
66
namespace Magento\Integration\Plugin\Model;
77

8+
use Magento\Framework\Model\AbstractModel;
89
use Magento\Integration\Model\CustomerTokenService;
10+
use Magento\Customer\Model\Customer;
911

1012
/**
1113
* Plugin to delete customer tokens when customer becomes inactive
@@ -29,18 +31,27 @@ public function __construct(
2931
/**
3032
* Check if customer is inactive - if so, invalidate their tokens
3133
*
32-
* @param \Magento\Customer\Model\Customer $subject
33-
* @param \Magento\Framework\DataObject $object
34-
* @return $this
34+
* @param Customer $subject
35+
* @param AbstractModel $object
36+
* @return AbstractModel
37+
*
38+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
3539
*/
3640
public function afterSave(
37-
\Magento\Customer\Model\Customer $subject,
38-
\Magento\Framework\DataObject $object
41+
Customer $subject,
42+
AbstractModel $object
3943
) {
4044
$isActive = $object->getIsActive();
4145
if (isset($isActive) && $isActive == 0) {
4246
$this->customerTokenService->revokeCustomerAccessToken($object->getId());
4347
}
44-
return $subject;
48+
return $object;
49+
}
50+
51+
public function afterDelete(Customer $subject, AbstractModel $return): AbstractModel
52+
{
53+
$this->customerTokenService->revokeCustomerAccessToken((int) $subject->getId());
54+
55+
return $return;
4556
}
4657
}

0 commit comments

Comments
 (0)