ENGCOM-6441: Code refactor in Catalog ViewModel Breadcrumbs #25920

Author: VladimirZaets

app/code/Magento/Catalog/Test/Unit/ViewModel/Product/BreadcrumbsTest.php

@@ -12,6 +12,7 @@
 use Magento\Catalog\ViewModel\Product\Breadcrumbs;
 use Magento\Framework\App\Config\ScopeConfigInterface;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
+use Magento\Framework\Serialize\Serializer\JsonHexTag;
 
 /**
  * Unit test for Magento\Catalog\ViewModel\Product\Breadcrumbs.
@@ -38,6 +39,11 @@ class BreadcrumbsTest extends \PHPUnit\Framework\TestCase
      */
     private $objectManager;
 
+    /**
+     * @var JsonHexTag|\PHPUnit_Framework_MockObject_MockObject
+     */
+    private $serializer;
+
     /**
      * @inheritdoc
      */
@@ -55,12 +61,15 @@ protected function setUp() : void
 
         $escaper = $this->getObjectManager()->getObject(\Magento\Framework\Escaper::class);
 
+        $this->serializer = $this->createMock(JsonHexTag::class);
+
         $this->viewModel = $this->getObjectManager()->getObject(
             Breadcrumbs::class,
             [
                 'catalogData' => $this->catalogHelper,
                 'scopeConfig' => $this->scopeConfig,
-                'escaper' => $escaper
+                'escaper' => $escaper,
+                'jsonSerializer' => $this->serializer
             ]
         );
     }
@@ -141,6 +150,8 @@ public function testGetJsonConfiguration($product, string $expectedJson) : void
             ->with('catalog/seo/category_url_suffix', \Magento\Store\Model\ScopeInterface::SCOPE_STORE)
             ->willReturn('."html');
 
+        $this->serializer->expects($this->once())->method('serialize')->willReturn($expectedJson);
+
         $this->assertEquals($expectedJson, $this->viewModel->getJsonConfiguration());
     }
 

app/code/Magento/Catalog/ViewModel/Product/Breadcrumbs.php

@@ -11,6 +11,7 @@
 use Magento\Framework\App\ObjectManager;
 use Magento\Framework\DataObject;
 use Magento\Framework\Serialize\Serializer\Json;
+use Magento\Framework\Serialize\Serializer\JsonHexTag;
 use Magento\Framework\View\Element\Block\ArgumentInterface;
 use Magento\Framework\Escaper;
 
@@ -36,24 +37,32 @@ class Breadcrumbs extends DataObject implements ArgumentInterface
      */
     private $escaper;
 
+    /**
+     * @var JsonHexTag
+     */
+    private $jsonSerializer;
+
     /**
      * @param Data $catalogData
      * @param ScopeConfigInterface $scopeConfig
      * @param Json|null $json
      * @param Escaper|null $escaper
+     * @param JsonHexTag|null $jsonSerializer
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function __construct(
         Data $catalogData,
         ScopeConfigInterface $scopeConfig,
         Json $json = null,
-        Escaper $escaper = null
+        Escaper $escaper = null,
+        JsonHexTag $jsonSerializer = null
     ) {
         parent::__construct();
 
         $this->catalogData = $catalogData;
         $this->scopeConfig = $scopeConfig;
         $this->escaper = $escaper ?: ObjectManager::getInstance()->get(Escaper::class);
+        $this->jsonSerializer = $jsonSerializer ?: ObjectManager::getInstance()->get(JsonHexTag::class);
     }
 
     /**
@@ -101,15 +110,14 @@ public function getProductName(): string
      */
     public function getJsonConfigurationHtmlEscaped() : string
     {
-        return json_encode(
+        return $this->jsonSerializer->serialize(
             [
                 'breadcrumbs' => [
                     'categoryUrlSuffix' => $this->escaper->escapeHtml($this->getCategoryUrlSuffix()),
                     'useCategoryPathInUrl' => (int)$this->isCategoryUsedInProductUrl(),
                     'product' => $this->escaper->escapeHtml($this->getProductName())
                 ]
-            ],
-            JSON_HEX_TAG
+            ]
         );
     }