Skip to content

Commit 177e972

Browse files
authored
ENGCOM-6938: Activated "Pending Reviews" menu item when merchant opens 'Pending Reviews' section #26230
2 parents 4f5f26c + 4ed1fa0 commit 177e972

File tree

4 files changed

+64
-0
lines changed

4 files changed

+64
-0
lines changed

app/code/Magento/Review/Controller/Adminhtml/Product/Pending.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ public function execute()
3131
}
3232
/** @var \Magento\Backend\Model\View\Result\Page $resultPage */
3333
$resultPage = $this->resultFactory->create(ResultFactory::TYPE_PAGE);
34+
$resultPage->setActiveMenu('Magento_Review::catalog_reviews_ratings_pending');
3435
$resultPage->getConfig()->getTitle()->prepend(__('Customer Reviews'));
3536
$resultPage->getConfig()->getTitle()->prepend(__('Pending Reviews'));
3637
$this->coreRegistry->register('usePendingFilter', true);
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
9+
<actionGroup name="AdminAssertClassElementRelativeIdActionGroup">
10+
<arguments>
11+
<argument name="elementId" type="string" defaultValue="{{AdminMenuSection.marketing}}"/>
12+
<argument name="expectClass" type="string" defaultValue="{{AdminMenuUserContentPendingReviews.activeClass}}" />
13+
</arguments>
14+
15+
<grabAttributeFrom selector="{{elementId}}" userInput="class" stepKey="grabClass"/>
16+
<assertContains stepKey="assertClass">
17+
<actualResult type="string">{$grabClass}</actualResult>
18+
<expectedResult type="string">{{expectClass}}</expectedResult>
19+
</assertContains>
20+
</actionGroup>
21+
</actionGroups>

app/code/Magento/Review/Test/Mftf/Data/AdminMenuData.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,12 @@
1313
<data key="title">Reviews</data>
1414
<data key="dataUiId">magento-review-catalog-reviews-ratings-reviews-all</data>
1515
</entity>
16+
<entity name="AdminMenuUserContentPendingReviews">
17+
<data key="pageTitle">Pending Reviews</data>
18+
<data key="title">Pending Reviews</data>
19+
<data key="dataUiId">magento-review-catalog-reviews-ratings-pending</data>
20+
<data key="dataActiveClass">_active</data>
21+
</entity>
1622
<entity name="AdminMenuReportsReviewsByCustomers">
1723
<data key="pageTitle">Customer Reviews Report</data>
1824
<data key="title">By Customers</data>
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
10+
<test name="AdminMarketingPendingReviewsNavigateMenuActiveTest">
11+
<annotations>
12+
<features value="Pending Reviews"/>
13+
<stories value="Menu Navigation"/>
14+
<title value="Admin marketing pending reviews navigate menu"/>
15+
<description value="Admin able see navigate head menu Marketing is active, when open page Marketing > Pending Reviews"/>
16+
<group value="menu"/>
17+
</annotations>
18+
<before>
19+
<actionGroup ref="LoginAsAdmin" stepKey="LoginAsAdmin"/>
20+
</before>
21+
<after>
22+
<actionGroup ref="logout" stepKey="logout"/>
23+
</after>
24+
<actionGroup ref="AdminNavigateMenuActionGroup" stepKey="navigateToReportsViewsPage">
25+
<argument name="menuUiId" value="{{AdminMenuMarketing.dataUiId}}"/>
26+
<argument name="submenuUiId" value="{{AdminMenuUserContentPendingReviews.dataUiId}}"/>
27+
</actionGroup>
28+
<actionGroup ref="AdminAssertPageTitleActionGroup" stepKey="seePageTitle">
29+
<argument name="title" value="{{AdminMenuUserContentPendingReviews.pageTitle}}"/>
30+
</actionGroup>
31+
<actionGroup ref="AdminAssertClassElementRelativeIdActionGroup" stepKey="assertClass">
32+
<argument name="elementId" value="{{AdminMenuSection.marketing}}"/>
33+
<argument name="expectClass" value="{{AdminMenuUserContentPendingReviews.dataActiveClass}}"/>
34+
</actionGroup>
35+
</test>
36+
</tests>

0 commit comments

Comments
 (0)