MC-41862: Stock status resets to saleable when the product is saved from Admin

Stanislav Idolov · Stanislav Idolov · commit 1707f2a81695 · 2021-09-27T11:47:47.000-05:00
diff --git a/app/code/Magento/CatalogInventory/Model/ResourceModel/Indexer/Stock/DefaultStock.php b/app/code/Magento/CatalogInventory/Model/ResourceModel/Indexer/Stock/DefaultStock.php
@@ -8,6 +8,7 @@
 
 use Magento\Catalog\Model\ResourceModel\Product\Indexer\AbstractIndexer;
 use Magento\CatalogInventory\Model\Stock;
+use Magento\Framework\App\ObjectManager;
 use Magento\Framework\DB\Adapter\AdapterInterface;
 use Magento\CatalogInventory\Api\StockConfigurationInterface;
 use Magento\CatalogInventory\Model\Indexer\Stock\Action\Full;
@@ -64,6 +65,11 @@ class DefaultStock extends AbstractIndexer implements StockInterface
      */
     private $actionType;
 
+    /**
+     * @var GetStatusExpression
+     */
+    private $getStatusExpression;
+
     /**
      * Class constructor
      *
@@ -72,16 +78,21 @@ class DefaultStock extends AbstractIndexer implements StockInterface
      * @param \Magento\Eav\Model\Config $eavConfig
      * @param \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig
      * @param string $connectionName
+     * @param \Magento\CatalogInventory\Model\ResourceModel\Indexer\Stock\GetStatusExpression|null $getStatusExpression
      */
     public function __construct(
         \Magento\Framework\Model\ResourceModel\Db\Context $context,
         \Magento\Framework\Indexer\Table\StrategyInterface $tableStrategy,
         \Magento\Eav\Model\Config $eavConfig,
         \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
-        $connectionName = null
+        $connectionName = null,
+        \Magento\CatalogInventory\Model\ResourceModel\Indexer\Stock\GetStatusExpression $getStatusExpression = null
     ) {
         $this->_scopeConfig = $scopeConfig;
         parent::__construct($context, $tableStrategy, $eavConfig, $connectionName);
+        $this->getStatusExpression = $getStatusExpression ?: ObjectManager::getInstance()->get(
+            \Magento\CatalogInventory\Model\ResourceModel\Indexer\Stock\GetStatusExpression::class
+        );
     }
 
     /**
@@ -251,6 +262,10 @@ protected function _getStockStatusSelect($entityIds = null, $usePrimaryTable = f
             . ' AND mcpei.attribute_id = ' . $this->_getAttribute('status')->getId()
             . ' AND mcpei.value = ' . ProductStatus::STATUS_ENABLED,
             []
+        )->joinLeft(
+            ['css' => 'cataloginventory_stock_status'],
+            'css.product_id = e.entity_id',
+            []
         )->columns(
             ['qty' => $qtyExpr]
         )->where(
@@ -292,14 +307,14 @@ protected function _prepareIndexTable($entityIds = null)
      */
     protected function _updateIndex($entityIds)
     {
-        $this->deleteOldRecords($entityIds);
         $connection = $this->getConnection();
         $select = $this->_getStockStatusSelect($entityIds, true);
         $select = $this->getQueryProcessorComposite()->processQuery($select, $entityIds, true);
         $query = $connection->query($select);
 
         $i = 0;
         $data = [];
+        $savedEntityIds = [];
         while ($row = $query->fetch(\PDO::FETCH_ASSOC)) {
             $i++;
             $data[] = [
@@ -309,6 +324,7 @@ protected function _updateIndex($entityIds)
                 'qty' => (double)$row['qty'],
                 'stock_status' => (int)$row['status'],
             ];
+            $savedEntityIds[] = (int)$row['entity_id'];
             if ($i % 1000 == 0) {
                 $this->_updateIndexTable($data);
                 $data = [];
@@ -317,6 +333,7 @@ protected function _updateIndex($entityIds)
 
         $this->_updateIndexTable($data);
 
+        $this->deleteOldRecords(array_diff($entityIds, $savedEntityIds));
         return $this;
     }
 
@@ -376,21 +393,7 @@ public function getIdxTable($table = null)
      */
     protected function getStatusExpression(AdapterInterface $connection, $isAggregate = false)
     {
-        $isInStockExpression = $isAggregate ? 'MAX(cisi.is_in_stock)' : 'cisi.is_in_stock';
-        if ($this->_isManageStock()) {
-            $statusExpr = $connection->getCheckSql(
-                'cisi.use_config_manage_stock = 0 AND cisi.manage_stock = 0',
-                1,
-                $isInStockExpression
-            );
-        } else {
-            $statusExpr = $connection->getCheckSql(
-                'cisi.use_config_manage_stock = 0 AND cisi.manage_stock = 1',
-                $isInStockExpression,
-                1
-            );
-        }
-        return $statusExpr;
+        return $this->getStatusExpression->execute($this->getTypeId(), $connection, $isAggregate);
     }
 
     /**
diff --git a/app/code/Magento/CatalogInventory/Model/ResourceModel/Indexer/Stock/GetStatusExpression.php b/app/code/Magento/CatalogInventory/Model/ResourceModel/Indexer/Stock/GetStatusExpression.php
@@ -0,0 +1,52 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\CatalogInventory\Model\ResourceModel\Indexer\Stock;
+
+use InvalidArgumentException;
+use Magento\CatalogInventory\Model\ResourceModel\Indexer\Stock\StatusExpression\ExpressionInterface;
+use Magento\Framework\DB\Adapter\AdapterInterface;
+use Zend_Db_Expr;
+
+class GetStatusExpression
+{
+    /**
+     * @var array
+     */
+    private $statusExpressions;
+
+    /**
+     * @param array $statusExpressions
+     */
+    public function __construct(array $statusExpressions = [])
+    {
+        foreach ($statusExpressions as $expression) {
+            if (!($expression instanceof ExpressionInterface)) {
+                throw new InvalidArgumentException(
+                    'Expressions must implement '
+                    .'\Magento\CatalogInventory\Model\ResourceModel\Indexer\Stock\StatusExpression\ExpressionInterface'
+                    .' interface'
+                );
+            }
+        }
+        $this->statusExpressions = $statusExpressions;
+    }
+
+    /**
+     * Returns stock status expression for MySQL query.
+     *
+     * @param string $productType
+     * @param AdapterInterface $connection
+     * @param bool $isAggregate
+     * @return Zend_Db_Expr|null
+     */
+    public function execute(string $productType, AdapterInterface $connection, bool $isAggregate): ?Zend_Db_Expr
+    {
+        $expression = $this->statusExpressions[$productType] ?? $this->statusExpressions['default'];
+        return $expression->getExpression($connection, $isAggregate);
+    }
+}
diff --git a/app/code/Magento/CatalogInventory/Model/ResourceModel/Indexer/Stock/StatusExpression/DefaultExpression.php b/app/code/Magento/CatalogInventory/Model/ResourceModel/Indexer/Stock/StatusExpression/DefaultExpression.php
@@ -0,0 +1,61 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\CatalogInventory\Model\ResourceModel\Indexer\Stock\StatusExpression;
+
+use Magento\CatalogInventory\Model\Configuration;
+use Magento\Framework\App\Config\ScopeConfigInterface;
+use Magento\Framework\DB\Adapter\AdapterInterface;
+use Magento\Store\Model\ScopeInterface;
+use Zend_Db_Expr;
+
+class DefaultExpression implements ExpressionInterface
+{
+    /**
+     * @var ScopeConfigInterface
+     */
+    private $scopeConfig;
+
+    /**
+     * @param ScopeConfigInterface $scopeConfig
+     */
+    public function __construct(ScopeConfigInterface $scopeConfig)
+    {
+        $this->scopeConfig = $scopeConfig;
+    }
+
+    /**
+     * Returns status expressions for MySQL query
+     *
+     * @ingeritdoc
+     * @param AdapterInterface $connection
+     * @param bool $isAggregate
+     * @return Zend_Db_Expr
+     */
+    public function getExpression(AdapterInterface $connection, bool $isAggregate): Zend_Db_Expr
+    {
+        $isManageStock = $this->scopeConfig->isSetFlag(
+            Configuration::XML_PATH_MANAGE_STOCK,
+            ScopeInterface::SCOPE_STORE
+        );
+
+        $isInStockExpression = $isAggregate ? 'MAX(cisi.is_in_stock)' : 'cisi.is_in_stock';
+        if ($isManageStock) {
+            $statusExpr = $connection->getCheckSql(
+                'cisi.use_config_manage_stock = 0 AND cisi.manage_stock = 0',
+                1,
+                $isInStockExpression
+            );
+        } else {
+            $statusExpr = $connection->getCheckSql(
+                'cisi.use_config_manage_stock = 0 AND cisi.manage_stock = 1',
+                $isInStockExpression,
+                1
+            );
+        }
+        return $statusExpr;
+    }
+}
diff --git a/app/code/Magento/CatalogInventory/Model/ResourceModel/Indexer/Stock/StatusExpression/ExpressionInterface.php b/app/code/Magento/CatalogInventory/Model/ResourceModel/Indexer/Stock/StatusExpression/ExpressionInterface.php
@@ -0,0 +1,25 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\CatalogInventory\Model\ResourceModel\Indexer\Stock\StatusExpression;
+
+use Magento\Framework\DB\Adapter\AdapterInterface;
+use Zend_Db_Expr;
+
+/**
+ * Interface for composite status expressions for MySQL query.
+ */
+interface ExpressionInterface
+{
+    /**
+     * Returns status expressions for MySQL query
+     *
+     * @param AdapterInterface $connection
+     * @param bool $isAggregate
+     * @return Zend_Db_Expr
+     */
+    public function getExpression(AdapterInterface $connection, bool $isAggregate): Zend_Db_Expr;
+}
diff --git a/app/code/Magento/CatalogInventory/etc/di.xml b/app/code/Magento/CatalogInventory/etc/di.xml
@@ -133,4 +133,11 @@
     <type name="Magento\Catalog\Controller\Adminhtml\Product\Action\Attribute\Save">
         <plugin name="massAction" type="Magento\CatalogInventory\Plugin\MassUpdateProductAttribute" />
     </type>
+    <type name="Magento\CatalogInventory\Model\ResourceModel\Indexer\Stock\GetStatusExpression">
+        <arguments>
+            <argument name="statusExpressions" xsi:type="array">
+                <item name="default" xsi:type="object">Magento\CatalogInventory\Model\ResourceModel\Indexer\Stock\StatusExpression\DefaultExpression</item>
+            </argument>
+        </arguments>
+    </type>
 </config>
diff --git a/dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/CategoryProductsVariantsTest.php b/dev/tests/api-functional/testsuite/Magento/GraphQl/Catalog/CategoryProductsVariantsTest.php
@@ -18,6 +18,7 @@
 class CategoryProductsVariantsTest extends GraphQlAbstract
 {
     /**
+     * @magentoApiDataFixture Magento/Catalog/_files/reindex_catalog_inventory_stock.php
      * @magentoApiDataFixture Magento/ConfigurableProduct/_files/product_configurable.php
      * @throws \Magento\Framework\Exception\NoSuchEntityException
      */
diff --git a/dev/tests/api-functional/testsuite/Magento/GraphQl/Sales/ReorderTest.php b/dev/tests/api-functional/testsuite/Magento/GraphQl/Sales/ReorderTest.php
@@ -56,7 +56,6 @@ protected function setUp(): void
         } catch (NoSuchEntityException $e) {
         }
     }
-
     /**
      * @magentoApiDataFixture Magento/Sales/_files/customer_order_item_with_product_and_custom_options.php
      */
@@ -188,15 +187,17 @@ public function testReorderWithLowStock()
     }
 
     /**
-     * Assert that simple product is not available.
+     * Assert that simple product is not available
      */
     private function assertProductNotAvailable()
     {
         $response = $this->makeReorderForDefaultCustomer();
         $expectedResponse = [
             'userInputErrors' => [
                 [
-                    'path' => ['orderNumber'],
+                    'path' => [
+                        'orderNumber'
+                    ],
                     'code' => 'NOT_SALABLE',
                 ],
             ],
diff --git a/dev/tests/integration/testsuite/Magento/Catalog/_files/products_list_rollback.php b/dev/tests/integration/testsuite/Magento/Catalog/_files/products_list_rollback.php
@@ -6,6 +6,9 @@
 declare(strict_types=1);
 
 /** @var \Magento\Framework\Registry $registry */
+
+use Magento\Framework\Indexer\IndexerRegistry;
+
 $registry = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->get(\Magento\Framework\Registry::class);
 
 $registry->unregister('isSecureArea');
@@ -37,6 +40,9 @@
     //Product already removed
 }
 
+\Magento\TestFramework\Helper\Bootstrap::getObjectManager()->get(IndexerRegistry::class)
+    ->get(Magento\CatalogInventory\Model\Indexer\Stock\Processor::INDEXER_ID)
+    ->reindexAll();
 
 $registry->unregister('isSecureArea');
 $registry->register('isSecureArea', false);
diff --git a/dev/tests/integration/testsuite/Magento/Catalog/_files/reindex_catalog_inventory_stock.php b/dev/tests/integration/testsuite/Magento/Catalog/_files/reindex_catalog_inventory_stock.php
@@ -0,0 +1,12 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+use Magento\CatalogInventory\Model\Indexer\Stock\Processor;
+use Magento\Framework\Indexer\IndexerRegistry;
+use Magento\TestFramework\Helper\Bootstrap;
+
+Bootstrap::getObjectManager()->get(IndexerRegistry::class)->get(Processor::INDEXER_ID)->reindexAll();
diff --git a/dev/tests/integration/testsuite/Magento/ConfigurableProduct/Block/Product/View/Type/ConfigurableViewOnCategoryPageTest.php b/dev/tests/integration/testsuite/Magento/ConfigurableProduct/Block/Product/View/Type/ConfigurableViewOnCategoryPageTest.php
@@ -102,6 +102,7 @@ public function testOutOfStockProductWithDisabledConfigView(): void
     }
 
     /**
+     * @magentoDataFixture Magento/Catalog/_files/reindex_catalog_inventory_stock.php
      * @magentoDataFixture Magento/ConfigurableProduct/_files/configurable_product_with_category.php
      *
      * @return void
diff --git a/dev/tests/integration/testsuite/Magento/ConfigurableProduct/_files/product_configurable.php b/dev/tests/integration/testsuite/Magento/ConfigurableProduct/_files/product_configurable.php
@@ -16,6 +16,7 @@
 use Magento\Eav\Model\Config;
 use Magento\TestFramework\Helper\Bootstrap;
 use Magento\TestFramework\Workaround\Override\Fixture\Resolver;
+use Magento\Framework\Indexer\IndexerRegistry;
 
 \Magento\TestFramework\Helper\Bootstrap::getInstance()->reinitialize();
 
@@ -118,6 +119,10 @@
         $itemResource->getMainTable(),
         'product_id = ' . $productToDelete->getId()
     );
+
+    \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->get(IndexerRegistry::class)
+        ->get(Magento\CatalogInventory\Model\Indexer\Stock\Processor::INDEXER_ID)
+        ->reindexAll();
 } catch (\Exception $e) {
     // Nothing to remove
 }

Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,7 @@`
`18`	`18`	`class CategoryProductsVariantsTest extends GraphQlAbstract`
`19`	`19`	`{`
`20`	`20`	`/**`
	`21`	`+ * @magentoApiDataFixture Magento/Catalog/_files/reindex_catalog_inventory_stock.php`
`21`	`22`	`* @magentoApiDataFixture Magento/ConfigurableProduct/_files/product_configurable.php`
`22`	`23`	`* @throws \Magento\Framework\Exception\NoSuchEntityException`
`23`	`24`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,6 @@ protected function setUp(): void`
`56`	`56`	`} catch (NoSuchEntityException $e) {`
`57`	`57`	`}`
`58`	`58`	`}`
`59`		`-`
`60`	`59`	`/**`
`61`	`60`	`* @magentoApiDataFixture Magento/Sales/_files/customer_order_item_with_product_and_custom_options.php`
`62`	`61`	`*/`
`@@ -188,15 +187,17 @@ public function testReorderWithLowStock()`
`188`	`187`	`}`
`189`	`188`
`190`	`189`	`/**`
`191`		`- * Assert that simple product is not available.`
	`190`	`+ * Assert that simple product is not available`
`192`	`191`	`*/`
`193`	`192`	`private function assertProductNotAvailable()`
`194`	`193`	`{`
`195`	`194`	`$response = $this->makeReorderForDefaultCustomer();`
`196`	`195`	`$expectedResponse = [`
`197`	`196`	`'userInputErrors' => [`
`198`	`197`	`[`
`199`		`- 'path' => ['orderNumber'],`
	`198`	`+ 'path' => [`
	`199`	`+ 'orderNumber'`
	`200`	`+ ],`
`200`	`201`	`'code' => 'NOT_SALABLE',`
`201`	`202`	`],`
`202`	`203`	`],`
Original file line number	Diff line number	Diff line change
`@@ -102,6 +102,7 @@ public function testOutOfStockProductWithDisabledConfigView(): void`
`102`	`102`	`}`
`103`	`103`
`104`	`104`	`/**`
	`105`	`+ * @magentoDataFixture Magento/Catalog/_files/reindex_catalog_inventory_stock.php`
`105`	`106`	`* @magentoDataFixture Magento/ConfigurableProduct/_files/configurable_product_with_category.php`
`106`	`107`	`*`
`107`	`108`	`* @return void`