MAGETWO-88631: Pr sprint 10 delivery

- fix static tests

Author: cpartica

app/code/Magento/CatalogGraphQl/Model/Layer/CollectionProvider.php

@@ -39,10 +39,10 @@ public function __construct(
 
     /**
      * @param \Magento\Catalog\Model\Category $category
-     * @return \Magento\CatalogSearch\Model\ResourceModel\Advanced\Collection
+     * @return Collection
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
-    public function getCollection(\Magento\Catalog\Model\Category $category)
+    public function getCollection(\Magento\Catalog\Model\Category $category) : Collection
     {
         if (!$this->collection) {
             $this->collection = $this->collectionFactory->create();

app/code/Magento/CatalogGraphQl/Model/Layer/Context.php

@@ -49,23 +49,23 @@ public function __construct(
     /**
      * @return ItemCollectionProviderInterface
      */
-    public function getCollectionProvider()
+    public function getCollectionProvider() : ItemCollectionProviderInterface
     {
         return $this->collectionProvider;
     }
 
     /**
      * @return StateKeyInterface
      */
-    public function getStateKey()
+    public function getStateKey() : StateKeyInterface
     {
         return $this->stateKey;
     }
 
     /**
      * @return CollectionFilterInterface
      */
-    public function getCollectionFilter()
+    public function getCollectionFilter() : CollectionFilterInterface
     {
         return $this->collectionFilter;
     }

app/code/Magento/CatalogGraphQl/Model/LayerFilterItemTypeResolver.php

@@ -3,7 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Magento\CatalogGraphQl\Model;
 

app/code/Magento/CatalogGraphQl/Model/LayerFilterItemTypeResolverComposite.php

@@ -3,7 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Magento\CatalogGraphQl\Model;
 

app/code/Magento/CatalogGraphQl/Model/Resolver/Layer/FilterableAttributesListFactory.php

@@ -8,9 +8,9 @@
 namespace Magento\CatalogGraphQl\Model\Resolver\Layer;
 
 use Magento\Catalog\Model\Layer\Category\FilterableAttributeList as CategoryFilterableAttributeList;
-use Magento\Catalog\Model\Layer\FilterList;
 use Magento\Catalog\Model\Layer\Resolver;
 use Magento\Catalog\Model\Layer\Search\FilterableAttributeList;
+use Magento\Catalog\Model\Layer\FilterableAttributeListInterface;
 
 /**
  * Factory for filterable attributes list.
@@ -22,11 +22,9 @@ class FilterableAttributesListFactory
      *
      * @var \Magento\Framework\ObjectManagerInterface
      */
-    private $objectManager = null;
+    private $objectManager;
 
     /**
-     * Factory constructor
-     *
      * @param \Magento\Framework\ObjectManagerInterface $objectManager
      */
     public function __construct(\Magento\Framework\ObjectManagerInterface $objectManager)
@@ -39,9 +37,9 @@ public function __construct(\Magento\Framework\ObjectManagerInterface $objectMan
      *
      * @param string $type
      * @param array $data
-     * @return FilterList
+     * @return FilterableAttributeListInterface
      */
-    public function create(string $type, array $data = array())
+    public function create(string $type, array $data = []) : FilterableAttributeListInterface
     {
         if ($type === Resolver::CATALOG_LAYER_CATEGORY) {
             return $this->objectManager->create(CategoryFilterableAttributeList::class, $data);

app/code/Magento/CatalogGraphQl/Model/Resolver/Layer/FiltersProvider.php

@@ -3,7 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Magento\CatalogGraphQl\Model\Resolver\Layer;
 
@@ -31,7 +31,6 @@ class FiltersProvider
     private $filterListFactory;
 
     /**
-     * FiltersProvider constructor.
      * @param Resolver $layerResolver
      * @param FilterableAttributesListFactory $filterableAttributesListFactory
      * @param FilterListFactory $filterListFactory

app/code/Magento/CatalogGraphQl/Model/Resolver/Products/Query/Filter.php

@@ -88,7 +88,7 @@ public function getResult(
      * @param ResolveInfo $info
      * @return string[]
      */
-    private function getProductFields(ResolveInfo $info)
+    private function getProductFields(ResolveInfo $info) : array
     {
         $fieldNames = [];
         foreach ($info->fieldNodes as $node) {

app/code/Magento/SwatchesGraphQl/Model/Resolver/SwatchLayerFilterItemResolver.php

@@ -3,7 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-declare(strict_types = 1);
+declare(strict_types=1);
 
 namespace Magento\SwatchesGraphQl\Model\Resolver;
 

app/code/Magento/SwatchesGraphQl/Plugin/Filters/DataProviderPlugin.php

@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\SwatchesGraphQl\Plugin\Filters;
 
@@ -12,8 +13,6 @@
 
 /**
  * Plugin to add swatch data to filters data from filters data provider.
- *
- * @package Magento\SwatchesGraphQl\Plugin\Filters
  */
 class DataProviderPlugin
 {
@@ -58,7 +57,7 @@ public function __construct(
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      */
-    public function aroundGetData(Filters $subject, \Closure $proceed, string $layerType)
+    public function aroundGetData(Filters $subject, \Closure $proceed, string $layerType) : array
     {
         $swatchFilters = [];
         /** @var AbstractFilter $filter */

dev/tests/api-functional/testsuite/Magento/GraphQl/Swatches/ProductSearchTest.php

@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\GraphQl\Swatches;