MAGETWO-38818: [Add join processors to search service] Tax Module - II

 - Add joinProcessor to Tax/Model/TaxClass/Repository.php
 - updated associated unit test
 - added integration test

Author: Cari Spruiell

app/code/Magento/Tax/Model/TaxClass/Repository.php

@@ -62,28 +62,36 @@ class Repository implements \Magento\Tax\Api\TaxClassRepositoryInterface
      */
     protected $taxClassResource;
 
+    /**
+     * @var \Magento\Framework\Api\ExtensionAttribute\JoinProcessorInterface
+     */
+    protected $joinProcessor;
+
     /**
      * @param SearchCriteriaBuilder $searchCriteriaBuilder
      * @param FilterBuilder $filterBuilder
      * @param TaxClassCollectionFactory $taxClassCollectionFactory
      * @param \Magento\Tax\Api\Data\TaxClassSearchResultsInterfaceFactory $searchResultsFactory
      * @param ClassModelRegistry $classModelRegistry
      * @param \Magento\Tax\Model\Resource\TaxClass $taxClassResource
+     * @param \Magento\Framework\Api\ExtensionAttribute\JoinProcessorInterface $joinProcessor
      */
     public function __construct(
         SearchCriteriaBuilder $searchCriteriaBuilder,
         FilterBuilder $filterBuilder,
         TaxClassCollectionFactory $taxClassCollectionFactory,
         \Magento\Tax\Api\Data\TaxClassSearchResultsInterfaceFactory $searchResultsFactory,
         ClassModelRegistry $classModelRegistry,
-        \Magento\Tax\Model\Resource\TaxClass $taxClassResource
+        \Magento\Tax\Model\Resource\TaxClass $taxClassResource,
+        \Magento\Framework\Api\ExtensionAttribute\JoinProcessorInterface $joinProcessor
     ) {
         $this->searchCriteriaBuilder = $searchCriteriaBuilder;
         $this->filterBuilder = $filterBuilder;
         $this->taxClassCollectionFactory = $taxClassCollectionFactory;
         $this->searchResultsFactory = $searchResultsFactory;
         $this->classModelRegistry = $classModelRegistry;
         $this->taxClassResource = $taxClassResource;
+        $this->joinProcessor = $joinProcessor;
     }
 
     /**
@@ -195,6 +203,7 @@ public function getList(\Magento\Framework\Api\SearchCriteriaInterface $searchCr
         $searchResults->setSearchCriteria($searchCriteria);
         /** @var TaxClassCollection $collection */
         $collection = $this->taxClassCollectionFactory->create();
+        $this->joinProcessor->process($collection);
         foreach ($searchCriteria->getFilterGroups() as $group) {
             $this->addFilterGroupToCollection($group, $collection);
         }

app/code/Magento/Tax/Test/Unit/Model/TaxClass/RepositoryTest.php

@@ -47,6 +47,12 @@ class RepositoryTest extends \PHPUnit_Framework_TestCase
      */
     protected $taxClassCollectionFactory;
 
+    /**
+     * @var \PHPUnit_Framework_MockObject_MockObject
+     */
+    protected $extensionAttributesJoinProcessorMock;
+
+    /**
     /**
      * @return void
      */
@@ -85,13 +91,23 @@ protected function setUp()
         );
 
         $this->taxClassResourceMock = $this->getMock('\Magento\Tax\Model\Resource\TaxClass', [], [], '', false);
+
+        $this->extensionAttributesJoinProcessorMock = $this->getMock(
+            '\Magento\Framework\Api\ExtensionAttribute\JoinProcessor',
+            ['process'],
+            [],
+            '',
+            false
+        );
+
         $this->model = $this->objectManager->getObject(
             'Magento\Tax\Model\TaxClass\Repository',
             [
                 'classModelRegistry' => $this->classModelRegistryMock,
                 'taxClassResource' => $this->taxClassResourceMock,
                 'searchResultsFactory' => $this->searchResultFactory,
-                'taxClassCollectionFactory' => $this->taxClassCollectionFactory
+                'taxClassCollectionFactory' => $this->taxClassCollectionFactory,
+                'joinProcessor' => $this->extensionAttributesJoinProcessorMock
             ]
         );
     }
@@ -187,6 +203,10 @@ public function testGetList()
         $collection = $this->getMock('\Magento\Tax\Model\Resource\TaxClass\Collection', [], [], '', false);
         $sortOrder = $this->getMock('\Magento\Framework\Api\SortOrder', [], [], '', false);
 
+        $this->extensionAttributesJoinProcessorMock->expects($this->once())
+            ->method('process')
+            ->with($collection);
+
         $searchCriteria->expects($this->once())->method('getFilterGroups')->willReturn([$filterGroup]);
         $filterGroup->expects($this->once())->method('getFilters')->willReturn([$filter]);
         $filter->expects($this->atLeastOnce())->method('getConditionType')->willReturn('eq');

dev/tests/integration/testsuite/Magento/Tax/Model/TaxClass/RepositoryTest.php

@@ -112,6 +112,29 @@ public function testGet()
         $this->assertEquals(TaxClassManagementInterface::TYPE_CUSTOMER, $data->getClassType());
     }
 
+    /**
+     * @magentoDbIsolation enabled
+     */
+    public function testGetList()
+    {
+        $taxClassName = 'Get Me';
+        $taxClassDataObject = $this->taxClassFactory->create();
+        $taxClassDataObject->setClassName($taxClassName)
+            ->setClassType(TaxClassManagementInterface::TYPE_CUSTOMER);
+        $taxClassId = $this->taxClassRepository->save($taxClassDataObject);
+        /** @var \Magento\Framework\Api\SearchCriteriaBuilder $searchCriteriaBuilder */
+        $searchCriteriaBuilder = Bootstrap::getObjectManager()->create('Magento\Framework\Api\SearchCriteriaBuilder');
+        /** @var \Magento\Tax\Api\Data\TaxClassSearchResultsInterface */
+        $searchResult = $this->taxClassRepository->getList($searchCriteriaBuilder->create());
+        $items = $searchResult->getItems();
+        /** @var \Magento\Tax\Api\Data\TaxClassInterface */
+        $taxClass = array_pop($items);
+        $this->assertInstanceOf('Magento\Tax\Api\Data\TaxClassInterface', $taxClass);
+        $this->assertEquals($taxClassName, $taxClass->getClassName());
+        $this->assertEquals($taxClassId, $taxClass->getClassId());
+        $this->assertEquals(TaxClassManagementInterface::TYPE_CUSTOMER, $taxClass->getClassType());
+    }
+
     /**
      * @expectedException \Magento\Framework\Exception\NoSuchEntityException
      * @expectedExceptionMessage No such entity with class_id = -9999