MAGETWO-58213: [GITHUB] Configurable products import doesn't work configurable_variations not imported #5876

Author: DianaRusin

app/code/Magento/ConfigurableImportExport/Model/Import/Product/Type/Configurable.php

@@ -470,9 +470,9 @@ protected function _processSuperData()
      * @param array $rowData
      *
      * @return array
+     * @throws LocalizedException
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      * @SuppressWarnings(PHPMD.NPathComplexity)
-     * @throws LocalizedException
      */
     protected function _parseVariations($rowData)
     {

dev/tests/integration/testsuite/Magento/ConfigurableImportExport/Model/Import/Product/Type/ConfigurableTest.php

@@ -156,6 +156,7 @@ public function testConfigurableImport($pathToFile, $productName, $optionSkuList
      * @magentoDataFixture Magento/ConfigurableProduct/_files/configurable_attribute.php
      * @magentoAppArea adminhtml
      * @magentoAppIsolation enabled
+     * @return void
      */
     public function testConfigurableImportWithMultipleStores()
     {
@@ -176,23 +177,21 @@ public function testConfigurableImportWithMultipleStores()
                 'directory' => $directory,
             ]
         );
-        $errors = $this->model->setSource(
-            $source
-        )->setParameters(
+        $errors = $this->model->setSource($source)->setParameters(
             [
                 'behavior' => \Magento\ImportExport\Model\Import::BEHAVIOR_APPEND,
                 'entity' => 'catalog_product',
             ]
         )->validateData();
 
-        $this->assertTrue($errors->getErrorsCount() == 0);
+        $this->assertTrue($errors->getErrorsCount() === 0);
         $this->model->importData();
 
         foreach ($products as $storeCode => $productName) {
             $store = $this->objectManager->create(\Magento\Store\Model\Store::class);
             $store->load($storeCode, 'code');
-            /** @var \Magento\Catalog\Api\ProductRepositoryInterface $productRepository */
-            $productRepository = $this->objectManager->get(\Magento\Catalog\Api\ProductRepositoryInterface::class);
+            /** @var ProductRepositoryInterface $productRepository */
+            $productRepository = $this->objectManager->get(ProductRepositoryInterface::class);
             /** @var \Magento\Catalog\Api\Data\ProductInterface $product */
             $product = $productRepository->get($productSku, 0, $store->getId());
             $this->assertFalse($product->isObjectNew());
@@ -206,35 +205,32 @@ public function testConfigurableImportWithMultipleStores()
      * @magentoDataFixture Magento/ConfigurableProduct/_files/configurable_attribute.php
      * @magentoDbIsolation disabled
      * @magentoAppArea adminhtml
+     * @return void
      */
     public function testConfigurableImportWithStoreSpecifiedMainItem()
     {
-        {
-            $expectedErrorMessage = 'Product with assigned super attributes should not have specified "store_view_code"'
-                . ' value';
-            $filesystem = $this->objectManager->create(
-                \Magento\Framework\Filesystem::class
-            );
-
-            $directory = $filesystem->getDirectoryWrite(DirectoryList::ROOT);
-            $source = $this->objectManager->create(
-                \Magento\ImportExport\Model\Import\Source\Csv::class,
-                [
-                    'file' =>  __DIR__ . '/../../_files/import_configurable_for_multiple_store_views_error.csv',
-                    'directory' => $directory,
-                ]
-            );
-            $errors = $this->model->setSource(
-                $source
-            )->setParameters(
-                [
-                    'behavior' => \Magento\ImportExport\Model\Import::BEHAVIOR_APPEND,
-                    'entity' => 'catalog_product',
-                ]
-            )->validateData();
-
-            $this->assertTrue($errors->getErrorsCount() == 1);
-            $this->assertEquals($expectedErrorMessage, $errors->getAllErrors()[0]->getErrorMessage());
-        }
+        $expectedErrorMessage = 'Product with assigned super attributes should not have specified "store_view_code"'
+            . ' value';
+        $filesystem = $this->objectManager->create(
+            \Magento\Framework\Filesystem::class
+        );
+
+        $directory = $filesystem->getDirectoryWrite(DirectoryList::ROOT);
+        $source = $this->objectManager->create(
+            \Magento\ImportExport\Model\Import\Source\Csv::class,
+            [
+                'file' =>  __DIR__ . '/../../_files/import_configurable_for_multiple_store_views_error.csv',
+                'directory' => $directory,
+            ]
+        );
+        $errors = $this->model->setSource($source)->setParameters(
+            [
+                'behavior' => \Magento\ImportExport\Model\Import::BEHAVIOR_APPEND,
+                'entity' => 'catalog_product',
+            ]
+        )->validateData();
+
+        $this->assertTrue($errors->getErrorsCount() === 1);
+        $this->assertEquals($expectedErrorMessage, $errors->getAllErrors()[0]->getErrorMessage());
     }
 }