MAGETWO-93305: Broken upgrade to 2.3 due to changed data type for minify_exclude

cpartica · cpartica · commit 169cab98b18e · 2018-08-30T11:36:09.000-05:00
- rename comment
diff --git a/lib/internal/Magento/Framework/View/Asset/Minification.php b/lib/internal/Magento/Framework/View/Asset/Minification.php
@@ -162,7 +162,7 @@ public function getExcludes($contentType)
     private function getMinificationExcludeValues($key)
     {
         $configValues = $this->scopeConfig->getValue($key, $this->scope) ?? [];
-        //compatibility fix for type change from new line separated string values to array
+        //value used to be a string separated by 'newline' separator so we need to convert it to array
         if (!is_array($configValues)) {
             $configValuesFromString = [];
             foreach (explode("\n", $configValues) as $exclude) {

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ public function getExcludes($contentType)`
`162`	`162`	`private function getMinificationExcludeValues($key)`
`163`	`163`	`{`
`164`	`164`	`$configValues = $this->scopeConfig->getValue($key, $this->scope) ?? [];`
`165`		`- //compatibility fix for type change from new line separated string values to array`
	`165`	`+ //value used to be a string separated by 'newline' separator so we need to convert it to array`
`166`	`166`	`if (!is_array($configValues)) {`
`167`	`167`	`$configValuesFromString = [];`
`168`	`168`	`foreach (explode("\n", $configValues) as $exclude) {`