Skip to content

Commit 169a2ec

Browse files
committed
Merge branch 'MC-11299' into 'MC-18826'
MC-18826: Increase test coverage for Cart & Checkout and Order Processing functional areas See merge request magn-m23/magn-m23!1701
2 parents c762344 + f70fd68 commit 169a2ec

File tree

1 file changed

+4
-20
lines changed

1 file changed

+4
-20
lines changed

dev/tests/integration/testsuite/Magento/Sales/Model/Order/ShipmentTest.php

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,6 @@ private function getOrder(string $incrementId): OrderInterface
155155
*/
156156
public function testGetTracksCollection()
157157
{
158-
$trackCount = 1;
159158
$order = $this->getOrder('100000001');
160159
$items = [];
161160
foreach ($order->getItems() as $item) {
@@ -197,25 +196,10 @@ public function testGetTracksCollection()
197196
$this->shipmentRepository->save($secondOrderShipment);
198197
$secondShipmentTrackCollection = $secondOrderShipment->getTracksCollection();
199198

200-
$shipmentId = $shipment->getId();
201-
$shipmentTrackIds = $shipmentTracksCollection->getColumnValues('parent_id');
202-
foreach ($shipmentTrackIds as $trackShipmentId) {
203-
self::assertEquals($shipmentId, $trackShipmentId);
204-
}
205-
self::assertCount($trackCount, $shipmentTrackIds);
206-
207-
$secondShipmentId = $secondOrderShipment->getId();
208-
$secondShipmentTrackIds = $secondShipmentTrackCollection->getColumnValues('parent_id');
209-
foreach ($secondShipmentTrackIds as $trackShipmentId) {
210-
self::assertEquals($secondShipmentId, $trackShipmentId);
211-
}
212-
self::assertCount($trackCount, $secondShipmentTrackIds);
213-
214-
self::assertEmpty(
215-
array_intersect(
216-
$shipmentTracksCollection->getColumnValues('id'),
217-
$secondShipmentTrackCollection->getColumnValues('id')
218-
)
199+
self::assertEquals($shipmentTracksCollection->getColumnValues('id'), [$track->getEntityId()]);
200+
self::assertEquals(
201+
$secondShipmentTrackCollection->getColumnValues('id'),
202+
[$secondShipmentTrack->getEntityId()]
219203
);
220204
}
221205
}

0 commit comments

Comments
 (0)