MC-30510: [Integration] PaymentFailuresServiceTest::testHandlerWithCustomer is flaky

Author: zakdma

dev/tests/integration/testsuite/Magento/Sales/Model/Service/PaymentFailuresServiceTest.php

@@ -7,10 +7,12 @@
 
 namespace Magento\Sales\Model\Service;
 
+use Magento\Framework\Stdlib\DateTime\TimezoneInterface;
 use Magento\Quote\Api\CartRepositoryInterface;
 use Magento\Quote\Model\Quote;
 use Magento\Sales\Api\PaymentFailuresInterface;
 use Magento\TestFramework\Helper\Bootstrap;
+use PHPUnit\Framework\MockObject\MockObject;
 
 /**
  * Tests \Magento\Sales\Api\PaymentFailuresInterface.
@@ -28,10 +30,15 @@ class PaymentFailuresServiceTest extends \PHPUnit\Framework\TestCase
     private $quote;
 
     /**
-     * @var CartRepositoryInterface|\PHPUnit_Framework_MockObject_MockObject
+     * @var CartRepositoryInterface|MockObject
      */
     private $cartRepositoryMock;
 
+    /**
+     * @var TimezoneInterface|MockObject
+     */
+    private $localeDateMock;
+
     /**
      * @inheritdoc
      */
@@ -42,11 +49,15 @@ protected function setUp()
             ->disableOriginalConstructor()
             ->setMethods(['get'])
             ->getMockForAbstractClass();
+        $this->localeDateMock = $this->getMockBuilder(TimezoneInterface::class)
+            ->setMethods(['formatDateTime'])
+            ->getMockForAbstractClass();
 
         $this->paymentFailures = Bootstrap::getObjectManager()->create(
             PaymentFailuresInterface::class,
             [
                 'cartRepository' => $this->cartRepositoryMock,
+                'localeDate' => $this->localeDateMock,
             ]
         );
     }
@@ -69,20 +80,19 @@ public function testHandlerWithCustomer(): void
             ->with($this->quote->getId())
             ->willReturn($this->quote);
 
+        $dateAndTime = 'Nov 22, 2019, 1:00:00 AM';
+        $this->localeDateMock->expects($this->atLeastOnce())->method('formatDateTime')->willReturn($dateAndTime);
         $this->paymentFailures->handle((int)$this->quote->getId(), $errorMessage->render());
 
         $paymentReflection = new \ReflectionClass($this->paymentFailures);
-        $templateTimeMethod = $paymentReflection->getMethod('getLocaleDate');
-        $templateTimeMethod->setAccessible(true);
-
         $templateVarsMethod = $paymentReflection->getMethod('getTemplateVars');
         $templateVarsMethod->setAccessible(true);
 
         $templateVars = $templateVarsMethod->invoke($this->paymentFailures, $this->quote, $errorMessage, $checkoutType);
         $expectedVars = [
-            'reason' => $errorMessage,
+            'reason' => $errorMessage->render(),
             'checkoutType' => $checkoutType,
-            'dateAndTime' => $templateTimeMethod->invoke($this->paymentFailures),
+            'dateAndTime' => $dateAndTime,
             'customer' => 'John Smith',
             'customerEmail' => 'aaa@aaa.com',
             'paymentMethod' => 'Some Title Of The Method',