MC-29423: GraphQL Send Friend is still sending emails when disabled

- use snake case for field names

Author: danielrenaud

app/code/Magento/SendFriendGraphQl/etc/schema.graphqls

@@ -39,7 +39,7 @@ type SendEmailToFriendRecipient {
 }
 
 type StoreConfig {
-    sendFriend: SendFriendConfiguration @resolver(class: "\\Magento\\SendFriendGraphQl\\Model\\Resolver\\SendFriendConfiguration") @doc(description: "Email to a Friend configuration.")
+    send_friend: SendFriendConfiguration @resolver(class: "\\Magento\\SendFriendGraphQl\\Model\\Resolver\\SendFriendConfiguration") @doc(description: "Email to a Friend configuration.")
 }
 
 type SendFriendConfiguration {

dev/tests/api-functional/testsuite/Magento/GraphQl/SendFriend/StoreConfigTest.php

@@ -20,11 +20,11 @@ public function testSendFriendFieldsAreReturnedWithoutError()
 
         $response = $this->graphQlQuery($query);
         $this->assertArrayNotHasKey('errors', $response);
-        $this->assertArrayHasKey('sendFriend', $response['storeConfig']);
-        $this->assertArrayHasKey('enabled_for_customers', $response['storeConfig']['sendFriend']);
-        $this->assertArrayHasKey('enabled_for_guests', $response['storeConfig']['sendFriend']);
-        $this->assertNotNull($response['storeConfig']['sendFriend']['enabled_for_customers']);
-        $this->assertNotNull($response['storeConfig']['sendFriend']['enabled_for_guests']);
+        $this->assertArrayHasKey('send_friend', $response['storeConfig']);
+        $this->assertArrayHasKey('enabled_for_customers', $response['storeConfig']['send_friend']);
+        $this->assertArrayHasKey('enabled_for_guests', $response['storeConfig']['send_friend']);
+        $this->assertNotNull($response['storeConfig']['send_friend']['enabled_for_customers']);
+        $this->assertNotNull($response['storeConfig']['send_friend']['enabled_for_guests']);
     }
 
     /**
@@ -77,11 +77,11 @@ public function testSendFriendEnabledGuestEnabled()
     private function assertResponse(array $expectedValues, array $response)
     {
         $this->assertArrayNotHasKey('errors', $response);
-        $this->assertArrayHasKey('sendFriend', $response['storeConfig']);
-        $this->assertArrayHasKey('enabled_for_customers', $response['storeConfig']['sendFriend']);
-        $this->assertArrayHasKey('enabled_for_guests', $response['storeConfig']['sendFriend']);
-        $this->assertEquals($expectedValues['enabled_for_customers'], $response['storeConfig']['sendFriend']['enabled_for_customers']);
-        $this->assertEquals($expectedValues['enabled_for_guests'], $response['storeConfig']['sendFriend']['enabled_for_guests']);
+        $this->assertArrayHasKey('send_friend', $response['storeConfig']);
+        $this->assertArrayHasKey('enabled_for_customers', $response['storeConfig']['send_friend']);
+        $this->assertArrayHasKey('enabled_for_guests', $response['storeConfig']['send_friend']);
+        $this->assertEquals($expectedValues['enabled_for_customers'], $response['storeConfig']['send_friend']['enabled_for_customers']);
+        $this->assertEquals($expectedValues['enabled_for_guests'], $response['storeConfig']['send_friend']['enabled_for_guests']);
     }
 
     /**
@@ -95,7 +95,7 @@ private function getStoreConfigQuery()
 {
     storeConfig{
         id
-        sendFriend {
+        send_friend {
             enabled_for_customers
             enabled_for_guests
         }