ENGCOM-7197: translate.js Not shows empty values #26417

magento-engcom-team · magento-engcom-team · commit 15cee4c0f43b · 2020-03-24T09:27:31.000-05:00
- Merge Pull Request #26417 from ilnytskyi/magento2:front-js-empty-translate - Merged commits: 1. adf9c65 2. 268b1ba 3. b09f0ec
diff --git a/dev/tests/js/jasmine/tests/lib/mage/translate.test.js b/dev/tests/js/jasmine/tests/lib/mage/translate.test.js
@@ -33,7 +33,8 @@ define([
 
             translation = {
                 'Hello World!': 'Hallo Welt!',
-                'Some text with symbols!-+"%#*': 'Ein Text mit Symbolen!-+"%#*'
+                'Some text with symbols!-+"%#*': 'Ein Text mit Symbolen!-+"%#*',
+                'Text with empty value': ''
             };
 
             $.mage.translate.add(translation);
diff --git a/lib/web/mage/translate.js b/lib/web/mage/translate.js
@@ -39,7 +39,7 @@ define([
                      * @return {String}
                      */
                     translate: function (text) {
-                        return _data[text] ? _data[text] : text;
+                        return typeof _data[text] !== 'undefined' ? _data[text] : text;
                     }
                 };
             }())

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ define([`
`39`	`39`	`* @return {String}`
`40`	`40`	`*/`
`41`	`41`	`translate: function (text) {`
`42`		`- return _data[text] ? _data[text] : text;`
	`42`	`+ return typeof _data[text] !== 'undefined' ? _data[text] : text;`
`43`	`43`	`}`
`44`	`44`	`};`
`45`	`45`	`}())`