Skip to content

Commit 1579242

Browse files
pradeep.rauthanpradeep.rauthan
authored andcommitted
Merge branch '2.4-develop' of https://github.com/magento-commerce/magento2ce into MC-42704
2 parents 2c9e530 + 84b69d1 commit 1579242

File tree

6 files changed

+13
-4
lines changed

6 files changed

+13
-4
lines changed

app/code/Magento/Ui/view/base/web/js/form/element/wysiwyg.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ define([
137137
if (this.$wysiwygEditorButton && disabled) {
138138
this.$wysiwygEditorButton.prop('disabled', 'disabled');
139139
} else if (this.$wysiwygEditorButton) {
140-
this.$wysiwygEditorButton.removeProp('disabled');
140+
this.$wysiwygEditorButton.prop('disabled', false);
141141
}
142142

143143
/* eslint-disable no-undef */

dev/tests/integration/framework/Magento/TestFramework/Helper/Amqp.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ class Amqp
1616
const CONFIG_PATH_HOST = 'queue/amqp/host';
1717
const CONFIG_PATH_USER = 'queue/amqp/user';
1818
const CONFIG_PATH_PASSWORD = 'queue/amqp/password';
19+
const DEFAULT_MANAGEMENT_PROTOCOL = 'http';
1920
const DEFAULT_MANAGEMENT_PORT = '15672';
2021

2122
/**
@@ -51,7 +52,10 @@ public function __construct(
5152
);
5253
$this->curl->addHeader('content-type', 'application/json');
5354
$this->host = sprintf(
54-
'http://%s:%s/api/',
55+
'%s://%s:%s/api/',
56+
defined('RABBITMQ_MANAGEMENT_PROTOCOL')
57+
? RABBITMQ_MANAGEMENT_PROTOCOL
58+
: self::DEFAULT_MANAGEMENT_PROTOCOL,
5559
$this->deploymentConfig->get(self::CONFIG_PATH_HOST),
5660
defined('RABBITMQ_MANAGEMENT_PORT') ? RABBITMQ_MANAGEMENT_PORT : self::DEFAULT_MANAGEMENT_PORT
5761
);

dev/tests/integration/phpunit.xml.dist

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@
8080
<!--<const name="MONGODB_CONNECTION_STRING" value="mongodb://localhost:27017"/>-->
8181
<!--<const name="MONGODB_DATABASE_NAME" value="magento_integration_tests"/>-->
8282
<!-- Connection parameters for RabbitMQ tests -->
83+
<!--<const name="RABBITMQ_MANAGEMENT_PROTOCOL" value="https"/>-->
8384
<!--<const name="RABBITMQ_MANAGEMENT_PORT" value="15672"/>-->
8485
<!--<const name="TESTS_PARALLEL_RUN" value="1"/>-->
8586
<const name="USE_OVERRIDE_CONFIG" value="enabled"/>

dev/tests/static/testsuite/Magento/Test/Js/_files/eslint/.eslintrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33
"./.eslintrc-reset",
44
"./.eslintrc-magento",
55
"./.eslintrc-jquery",
6-
"./.eslintrc-tinymce"
6+
"./.eslintrc-misc"
77
]
88
}

dev/tests/static/testsuite/Magento/Test/Js/_files/eslint/.eslintrc-tinymce renamed to dev/tests/static/testsuite/Magento/Test/Js/_files/eslint/.eslintrc-misc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,10 @@
7878
message: "'mobile' theme is removed. Update code to be compatible with tinymce5",
7979
selector: "ObjectExpression > Property[key.name='theme'][value.value='mobile']"
8080
},
81+
{
82+
message: "This method should not be used to remove built-in (native) properties",
83+
selector: "CallExpression[callee.property.name='removeProp'] > :matches([arguments] Literal[value='disabled'], Literal[value='checked'], Literal[value='selected'], Literal[value='required'], Literal[value='value'], Literal[value='readOnly'])"
84+
}
8185
]
8286
}
8387
}

lib/web/mage/adminhtml/wysiwyg/tiny_mce/tinymce5Adapter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -644,7 +644,7 @@ define([
644644
}
645645

646646
if (enabled) {
647-
this.getTextArea().removeProp('disabled');
647+
this.getTextArea().prop('disabled', false);
648648
} else {
649649
this.getTextArea().prop('disabled', 'disabled');
650650
}

0 commit comments

Comments
 (0)