Skip to content

Commit 155d879

Browse files
committed
Fix position after change preview image
1 parent 0648d3d commit 155d879

File tree

1 file changed

+28
-15
lines changed

1 file changed

+28
-15
lines changed

app/code/Magento/ProductVideo/view/adminhtml/web/js/new-video-dialog.js

Lines changed: 28 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,9 @@ define([
424424
*/
425425
_replaceImage: function (oldFile, newFile, imageData) {
426426
var tmpNewFile = newFile,
427+
tmpOldImage,
427428
newImageId,
429+
oldNewFilePosition,
428430
fc,
429431
suff,
430432
searchsuff,
@@ -433,6 +435,7 @@ define([
433435

434436
oldFile = this.__prepareFilename(oldFile);
435437
newFile = this.__prepareFilename(newFile);
438+
tmpOldImage = this._images[oldFile];
436439

437440
if (newFile === oldFile) {
438441
this._images[newFile] = imageData;
@@ -444,26 +447,36 @@ define([
444447
this._removeImage(oldFile);
445448
this._setImage(newFile, imageData);
446449

447-
if (oldFile && imageData.oldFile) {
448-
newImageId = this.findElementId(tmpNewFile);
449-
fc = $(this._itemIdSelector).val();
450+
if (!oldFile || !imageData.oldFile) {
451+
return null;
452+
}
450453

451-
suff = 'product[media_gallery][images]' + fc;
454+
newImageId = this.findElementId(tmpNewFile);
455+
fc = $(this._itemIdSelector).val();
452456

453-
searchsuff = 'input[name="' + suff + '[value_id]"]';
454-
key = $(searchsuff).val();
457+
suff = 'product[media_gallery][images]' + fc;
455458

456-
if (!key) {
457-
return null;
458-
}
459+
searchsuff = 'input[name="' + suff + '[value_id]"]';
460+
key = $(searchsuff).val();
459461

460-
oldValIdElem = document.createElement('input');
461-
$('form[data-form="edit-product"]').append(oldValIdElem);
462-
$(oldValIdElem).attr({
463-
type: 'hidden',
464-
name: 'product[media_gallery][images][' + newImageId + '][save_data_from]'
465-
}).val(key);
462+
if (!key) {
463+
return null;
466464
}
465+
466+
oldValIdElem = document.createElement('input');
467+
$('form[data-form="edit-product"]').append(oldValIdElem);
468+
$(oldValIdElem).attr({
469+
type: 'hidden',
470+
name: 'product[media_gallery][images][' + newImageId + '][save_data_from]'
471+
}).val(key);
472+
473+
oldNewFilePosition = parseInt(tmpOldImage.position);
474+
imageData.position = oldNewFilePosition;
475+
476+
$(this._imageWidgetSelector).trigger('setPosition', {
477+
imageData: imageData,
478+
position: oldNewFilePosition
479+
});
467480
},
468481

469482
/**

0 commit comments

Comments
 (0)