Skip to content

Commit 1549426

Browse files
author
Joan He
committed
Merge remote-tracking branch 'arcticfoxes/MC-15575' into 2.3-qwerty-pr
2 parents 18fca45 + 9d58421 commit 1549426

File tree

2 files changed

+9
-2
lines changed
  • app/code/Magento/Email/Model/Template
  • dev/tests/integration/testsuite/Magento/Email/Model/Template

2 files changed

+9
-2
lines changed

app/code/Magento/Email/Model/Template/Filter.php

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,6 +321,8 @@ public function setDesignParams(array $designParams)
321321
}
322322

323323
/**
324+
* Get Css processor
325+
*
324326
* @deprecated 100.1.2
325327
* @return Css\Processor
326328
*/
@@ -333,6 +335,8 @@ private function getCssProcessor()
333335
}
334336

335337
/**
338+
* Get pub directory
339+
*
336340
* @deprecated 100.1.2
337341
* @param string $dirType
338342
* @return ReadInterface
@@ -523,6 +527,7 @@ public function mediaDirective($construction)
523527

524528
/**
525529
* Retrieve store URL directive
530+
*
526531
* Support url and direct_url properties
527532
*
528533
* @param string[] $construction
@@ -849,7 +854,7 @@ public function cssDirective($construction)
849854
return $css;
850855
} else {
851856
// Return CSS comment for debugging purposes
852-
return '/* ' . sprintf(__('Contents of %s could not be loaded or is empty'), $file) . ' */';
857+
return '/* ' . __('Contents of the specified CSS file could not be loaded or is empty') . ' */';
853858
}
854859
}
855860

@@ -958,6 +963,8 @@ public function getCssFilesContent(array $files)
958963
}
959964

960965
/**
966+
* Apply inline css
967+
*
961968
* Merge HTML and CSS and return HTML that has CSS styles applied "inline" to the HTML tags. This is necessary
962969
* in order to support all email clients.
963970
*

dev/tests/integration/testsuite/Magento/Email/Model/Template/FilterTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ public function cssDirectiveDataProvider()
267267
'Empty or missing file' => [
268268
TemplateTypesInterface::TYPE_HTML,
269269
'file="css/non-existent-file.css"',
270-
'/* Contents of css/non-existent-file.css could not be loaded or is empty */'
270+
'/* Contents of the specified CSS file could not be loaded or is empty */'
271271
],
272272
'File with compilation error results in error message' => [
273273
TemplateTypesInterface::TYPE_HTML,

0 commit comments

Comments
 (0)