MAGETWO-63382: CLI Improvements: Configuration management - Command config:show

Author: Bohdan Korablov

app/code/Magento/Config/Console/Command/ConfigShow/ValueProcessor.php

@@ -14,9 +14,7 @@
 use Magento\Framework\App\Area;
 
 /**
- * Class processes values using backend model.
- *
- * Backend model is gotten from field via its path (e.g. scope_id/group_id/field_id).
+ * Class processes values using backend model which declared in system.xml.
  */
 class ValueProcessor
 {

lib/internal/Magento/Framework/App/Config/ConfigPathResolver.php

@@ -8,7 +8,7 @@
 use Magento\Store\Model\ScopeInterface;
 
 /**
- * Resolves config path by input parameters.
+ * Configures full path for configurations, including scope data and configuration type.
  */
 class ConfigPathResolver
 {
@@ -31,19 +31,22 @@ public function __construct(ScopeCodeResolver $scopeCodeResolver)
      *
      * @param string $path The path of configuration
      * @param string $scope The scope of configuration
-     * @param string|int|null $scopeCode The scope code or identifier of configuration
-     * @param string|null $type The type of configuration
+     * @param string|int|null $scopeCode The scope code or its identifier of configuration. The values for this
+     * field are taken from 'store' or 'store_website' tables, depends on $scope value
+     * @param string|null $type The type of configuration.
+     * The available types are declared in implementations of Magento\Framework\App\Config\ConfigTypeInterface
+     * E.g.
+     * ```php
+     * const CONFIG_TYPE = 'system';
+     * ```
      * @return string Resolved configuration path
      */
     public function resolve($path, $scope = ScopeConfigInterface::SCOPE_TYPE_DEFAULT, $scopeCode = null, $type = null)
     {
         $path = trim($path, '/');
         $scope = rtrim($scope, 's');
 
-        /**
-         * Scope name is currently stored in plural form.
-         * Desired behavior will be changed in mayor release.
-         */
+        /** Scope name is currently stored in plural form. */
         if (in_array($scope, [ScopeInterface::SCOPE_STORE, ScopeInterface::SCOPE_WEBSITE])) {
             $scope .= 's';
         }
@@ -58,6 +61,6 @@ public function resolve($path, $scope = ScopeConfigInterface::SCOPE_TYPE_DEFAULT
             $scopePath .= '/' . $scopeCode;
         }
 
-        return trim($scopePath . '/' . $path, '/');
+        return $scopePath . ($path ? '/' . $path : '');
     }
 }

lib/internal/Magento/Framework/App/Config/ConfigSourceAggregated.php

@@ -40,7 +40,7 @@ public function get($path = '')
             $configData = $source->get($path);
             if (!is_array($configData)) {
                 $data = $configData;
-            } elseif(!empty($configData)) {
+            } elseif (!empty($configData)) {
                 $data = array_replace_recursive(is_array($data) ? $data : [], $configData);
             }
         }

lib/internal/Magento/Framework/App/Config/ConfigSourceInterface.php

@@ -15,8 +15,23 @@ interface ConfigSourceInterface
     /**
      * Retrieve configuration raw data array.
      *
-     * @param string $path
-     * @return string|array
+     * @param string $path The configuration path (e.g. section_id/group_id/field_id)
+     * @return string|array Array will be returned if you use part of path (e.g. scope/scope_code/section_id)
+     * ```php
+     * [
+     *      'group1' =>
+     *      [
+     *          'field1' => 'value1',
+     *          'field2' => 'value2'
+     *      ],
+     *      'group2' =>
+     *      [
+     *          'field1' => 'value3'
+     *      ]
+     * ]
+     * ```
+     * And string will be returned if you use full path to field (e.g. scope/scope_code/section_id/group_id/field_id)
+     * E.g. 'value1'
      */
     public function get($path = '');
 }