Skip to content

Commit 14b083d

Browse files
pdohogne-magentopdohogne-magento
committed
Merge branch 'MAGETWO-69577-autogenerated-classes-behave-differently' into Borg-PR-11-29
2 parents 0cb522b + 13286b7 commit 14b083d

File tree

28 files changed

+631
-405
lines changed

28 files changed

+631
-405
lines changed

‎app/autoload.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,3 @@
3535
}
3636

3737
AutoloaderRegistry::registerAutoloader(new ClassLoaderWrapper($composerAutoloader));
38-
39-
// Sets default autoload mappings, may be overridden in Bootstrap::create
40-
\Magento\Framework\App\Bootstrap::populateAutoloader(BP, []);

‎app/bootstrap.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@
2828
}
2929

3030
require_once __DIR__ . '/autoload.php';
31+
// Sets default autoload mappings, may be overridden in Bootstrap::create
32+
\Magento\Framework\App\Bootstrap::populateAutoloader(BP, []);
33+
3134
require_once BP . '/app/functions.php';
3235

3336
/* Custom umask value may be provided in optional mage_umask file in root */

‎app/code/Magento/CatalogInventory/Test/Unit/Model/Plugin/AfterProductLoadTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ protected function setUp()
5252
->with($productId)
5353
->willReturn($stockItemMock);
5454

55-
$this->productExtensionMock = $this->getMockBuilder('\Magento\Catalog\Api\Data\ProductExtension')
55+
$this->productExtensionMock = $this->getMockBuilder('\Magento\Catalog\Api\Data\ProductExtensionInterface')
5656
->setMethods(['setStockItem'])
5757
->getMock();
5858
$this->productExtensionMock->expects($this->once())

‎app/code/Magento/Customer/Test/Unit/Model/Renderer/RegionTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ class RegionTest extends \PHPUnit_Framework_TestCase
1414
public function testRender($regionCollection)
1515
{
1616
$countryFactoryMock = $this->getMock(
17-
'Magento\Directory\Model\CountryFactory',
18-
['create'],
17+
\Magento\Directory\Model\CountryFactory::class,
18+
[],
1919
[],
2020
'',
2121
false

‎app/code/Magento/Directory/Model/CountryFactory.php

Lines changed: 0 additions & 39 deletions
This file was deleted.

‎app/code/Magento/Downloadable/Test/Unit/Model/Sales/Order/Pdf/Items/CreditmemoTest.php

Lines changed: 26 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -10,71 +10,30 @@ class CreditmemoTest extends \PHPUnit_Framework_TestCase
1010
/**
1111
* @var \Magento\Downloadable\Model\Sales\Order\Pdf\Items\Creditmemo
1212
*/
13-
protected $_model;
13+
private $model;
1414

1515
/**
1616
* @var \Magento\Sales\Model\Order|\PHPUnit_Framework_MockObject_MockObject
1717
*/
18-
protected $_order;
18+
private $order;
1919

2020
/**
2121
* @var \Magento\Sales\Model\Order\Pdf\AbstractPdf|\PHPUnit_Framework_MockObject_MockObject
2222
*/
23-
protected $_pdf;
23+
private $pdf;
2424

2525
protected function setUp()
2626
{
2727
$objectManager = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
28-
$arguments = [
29-
'productFactory' => $this->getMock('Magento\Catalog\Model\ProductFactory', [], [], '', false),
30-
'orderItemCollectionFactory' => $this->getMock(
31-
'Magento\Sales\Model\ResourceModel\Order\Item\CollectionFactory',
32-
[],
33-
[],
34-
'',
35-
false
36-
),
37-
'serviceOrderFactory' => $this->getMock(
38-
'Magento\Sales\Model\Service\OrderFactory',
39-
[],
40-
[],
41-
'',
42-
false
43-
),
44-
'currencyFactory' => $this->getMock(
45-
'Magento\Directory\Model\CurrencyFactory',
46-
[],
47-
[],
48-
'',
49-
false
50-
),
51-
'orderHistoryFactory' => $this->getMock(
52-
'Magento\Sales\Model\Order\Status\HistoryFactory',
53-
[],
54-
[],
55-
'',
56-
false
57-
),
58-
'orderTaxCollectionFactory' => $this->getMock(
59-
'Magento\Tax\Model\ResourceModel\Sales\Order\Tax\CollectionFactory',
60-
[],
61-
[],
62-
'',
63-
false
64-
),
65-
];
66-
$orderConstructorArgs = $objectManager->getConstructArguments('Magento\Sales\Model\Order', $arguments);
67-
$this->_order = $this->getMock('Magento\Sales\Model\Order', ['formatPriceTxt'], $orderConstructorArgs);
68-
$this->_order->expects(
69-
$this->any()
70-
)->method(
71-
'formatPriceTxt'
72-
)->will(
73-
$this->returnCallback([$this, 'formatPrice'])
74-
);
28+
$this->order = $this->getMockBuilder(\Magento\Sales\Model\Order::class)
29+
->disableOriginalConstructor()
30+
->getMock();
31+
$this->order->expects($this->any())
32+
->method('formatPriceTxt')
33+
->will($this->returnCallback([$this, 'formatPrice']));
7534

76-
$this->_pdf = $this->getMock(
77-
'Magento\Sales\Model\Order\Pdf\AbstractPdf',
35+
$this->pdf = $this->getMock(
36+
\Magento\Sales\Model\Order\Pdf\AbstractPdf::class,
7837
['drawLineBlocks', 'getPdf'],
7938
[],
8039
'',
@@ -96,22 +55,22 @@ protected function setUp()
9655
['string' => new \Magento\Framework\Stdlib\StringUtils(), 'filterManager' => $filterManager]
9756
);
9857

99-
$this->_model = $this->getMock(
100-
'Magento\Downloadable\Model\Sales\Order\Pdf\Items\Creditmemo',
58+
$this->model = $this->getMock(
59+
\Magento\Downloadable\Model\Sales\Order\Pdf\Items\Creditmemo::class,
10160
['getLinks', 'getLinksTitle'],
10261
$modelConstructorArgs
10362
);
10463

105-
$this->_model->setOrder($this->_order);
106-
$this->_model->setPdf($this->_pdf);
107-
$this->_model->setPage(new \Zend_Pdf_Page('a4'));
64+
$this->model->setOrder($this->order);
65+
$this->model->setPdf($this->pdf);
66+
$this->model->setPage(new \Zend_Pdf_Page('a4'));
10867
}
10968

11069
protected function tearDown()
11170
{
112-
$this->_model = null;
113-
$this->_order = null;
114-
$this->_pdf = null;
71+
$this->model = null;
72+
$this->order = null;
73+
$this->pdf = null;
11574
}
11675

11776
/**
@@ -150,7 +109,7 @@ public function testDraw()
150109
],
151110
];
152111

153-
$this->_model->setItem(
112+
$this->model->setItem(
154113
new \Magento\Framework\DataObject(
155114
[
156115
'name' => 'Downloadable Documentation',
@@ -170,8 +129,8 @@ public function testDraw()
170129
]
171130
)
172131
);
173-
$this->_model->expects($this->any())->method('getLinksTitle')->will($this->returnValue('Download Links'));
174-
$this->_model->expects(
132+
$this->model->expects($this->any())->method('getLinksTitle')->will($this->returnValue('Download Links'));
133+
$this->model->expects(
175134
$this->any()
176135
)->method(
177136
'getLinks'
@@ -184,7 +143,7 @@ public function testDraw()
184143
)
185144
)
186145
);
187-
$this->_pdf->expects(
146+
$this->pdf->expects(
188147
$this->once()
189148
)->method(
190149
'drawLineBlocks'
@@ -196,8 +155,8 @@ public function testDraw()
196155
$this->returnValue($expectedPdfPage)
197156
);
198157

199-
$this->assertNotSame($expectedPdfPage, $this->_model->getPage());
200-
$this->assertNull($this->_model->draw());
201-
$this->assertSame($expectedPdfPage, $this->_model->getPage());
158+
$this->assertNotSame($expectedPdfPage, $this->model->getPage());
159+
$this->assertNull($this->model->draw());
160+
$this->assertSame($expectedPdfPage, $this->model->getPage());
202161
}
203162
}

‎app/code/Magento/Paypal/Test/Unit/Model/PayflowproTest.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,10 @@ protected function setUp()
118118
$client->expects($this->any())->method('request')->will($this->returnSelf());
119119
$client->expects($this->any())->method('getBody')->will($this->returnValue('RESULT name=value&name2=value2'));
120120

121-
$clientFactory = $this->getMock('Magento\Framework\HTTP\ZendClientFactory', ['create'], [], '', false);
122-
$clientFactory->expects($this->any())->method('create')->will($this->returnValue($client));
121+
$clientFactory = $this->getMockBuilder(ZendClientFactory::class)
122+
->disableOriginalConstructor()
123+
->getMock();
124+
$clientFactory->method('create')->will($this->returnValue($client));
123125

124126
$this->eventManager = $this->getMockForAbstractClass(ManagerInterface::class);
125127

‎app/code/Magento/Review/Test/Unit/Model/ResourceModel/Review/Product/CollectionTest.php

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -65,16 +65,25 @@ protected function setUp()
6565
false
6666
);
6767
$fetchStrategy->expects($this->any())->method('fetchAll')->will($this->returnValue([]));
68-
$this->model = (new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this))
69-
->getObject(
70-
'\Magento\Review\Model\ResourceModel\Review\Product\Collection',
71-
[
72-
'universalFactory' => $universalFactory,
73-
'storeManager' => $storeManager,
74-
'eavConfig' => $eavConfig,
75-
'fetchStrategy' => $fetchStrategy
76-
]
77-
);
68+
$productLimitationMock = $this->getMock(
69+
\Magento\Catalog\Model\ResourceModel\Product\Collection\ProductLimitation::class
70+
);
71+
$productLimitationFactoryMock = $this->getMockBuilder(ProductLimitationFactory::class)
72+
->disableOriginalConstructor()
73+
->getMock();
74+
$productLimitationFactoryMock->method('create')
75+
->willReturn($productLimitationMock);
76+
$this->objectManager = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
77+
$this->model = $this->objectManager->getObject(
78+
\Magento\Review\Model\ResourceModel\Review\Product\Collection::class,
79+
[
80+
'universalFactory' => $universalFactory,
81+
'storeManager' => $storeManager,
82+
'eavConfig' => $eavConfig,
83+
'fetchStrategy' => $fetchStrategy,
84+
'productLimitationFactory' => $productLimitationFactoryMock
85+
]
86+
);
7887
}
7988

8089
/**

‎app/code/Magento/Sales/Test/Unit/Controller/Adminhtml/Order/CreditmemoLoaderTest.php

Lines changed: 12 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -14,62 +14,57 @@ class CreditmemoLoaderTest extends \PHPUnit_Framework_TestCase
1414
/**
1515
* @var \Magento\Sales\Controller\Adminhtml\Order\CreditmemoLoader
1616
*/
17-
protected $loader;
17+
private $loader;
1818

1919
/**
2020
* @var \Magento\Sales\Api\CreditmemoRepositoryInterface|\PHPUnit_Framework_MockObject_MockObject
2121
*/
22-
protected $creditmemoRepositoryMock;
22+
private $creditmemoRepositoryMock;
2323

2424
/**
2525
* @var \Magento\Sales\Model\Order\CreditmemoFactory|\PHPUnit_Framework_MockObject_MockObject
2626
*/
27-
protected $creditmemoFactoryMock;
27+
private $creditmemoFactoryMock;
2828

2929
/**
3030
* @var \PHPUnit_Framework_MockObject_MockObject
3131
*/
32-
protected $orderFactoryMock;
32+
private $orderFactoryMock;
3333

3434
/**
3535
* @var \PHPUnit_Framework_MockObject_MockObject
3636
*/
37-
protected $invoiceRepositoryMock;
37+
private $invoiceRepositoryMock;
3838

3939
/**
4040
* @var \PHPUnit_Framework_MockObject_MockObject
4141
*/
42-
protected $serviceOrderFactoryMock;
42+
private $eventManagerMock;
4343

4444
/**
4545
* @var \PHPUnit_Framework_MockObject_MockObject
4646
*/
47-
protected $eventManagerMock;
47+
private $sessionMock;
4848

4949
/**
5050
* @var \PHPUnit_Framework_MockObject_MockObject
5151
*/
52-
protected $sessionMock;
52+
private $messageManagerMock;
5353

5454
/**
5555
* @var \PHPUnit_Framework_MockObject_MockObject
5656
*/
57-
protected $messageManagerMock;
57+
private $registryMock;
5858

5959
/**
6060
* @var \PHPUnit_Framework_MockObject_MockObject
6161
*/
62-
protected $registryMock;
62+
private $helperMock;
6363

6464
/**
6565
* @var \PHPUnit_Framework_MockObject_MockObject
6666
*/
67-
protected $helperMock;
68-
69-
/**
70-
* @var \PHPUnit_Framework_MockObject_MockObject
71-
*/
72-
protected $stockConfiguration;
67+
private $stockConfiguration;
7368

7469
protected function setUp()
7570
{
@@ -86,11 +81,7 @@ protected function setUp()
8681
->disableOriginalConstructor()
8782
->setMethods(['create'])
8883
->getMockForAbstractClass();
89-
$this->serviceOrderFactoryMock = $this->getMockBuilder('Magento\Sales\Model\Service\OrderFactory')
90-
->disableOriginalConstructor()
91-
->setMethods(['create'])
92-
->getMock();
93-
$this->eventManagerMock = $this->getMockBuilder('Magento\Framework\Event\Manager')
84+
$this->eventManagerMock = $this->getMockBuilder(\Magento\Framework\Event\Manager::class)
9485
->disableOriginalConstructor()
9586
->setMethods([])
9687
->getMock();

‎app/code/Magento/Sales/Test/Unit/Model/Order/CreditmemoDocumentFactoryTest.php

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
namespace Magento\Sales\Test\Unit\Model\Order;
77

88
use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
9+
use Magento\Sales\Api\Data\CreditmemoCommentInterfaceFactory;
910
use Magento\Sales\Api\OrderRepositoryInterface;
1011
use Magento\Sales\Model\Order\CreditmemoDocumentFactory;
1112
use Magento\Sales\Api\Data\CreditmemoCommentInterface;
@@ -41,7 +42,7 @@ class CreditmemoDocumentFactoryTest extends \PHPUnit_Framework_TestCase
4142
private $creditmemoFactoryMock;
4243

4344
/**
44-
* @var \Magento\Sales\Api\Data\CreditmemoCommentInterfaceFactory|\PHPUnit_Framework_MockObject_MockObject
45+
* @var CreditmemoCommentInterfaceFactory|\PHPUnit_Framework_MockObject_MockObject
4546
*/
4647
private $commentFactoryMock;
4748

@@ -101,11 +102,9 @@ public function setUp()
101102
$this->creditmemoFactoryMock = $this->getMockBuilder(CreditmemoFactory::class)
102103
->disableOriginalConstructor()
103104
->getMock();
104-
$this->commentFactoryMock =
105-
$this->getMockBuilder('Magento\Sales\Api\Data\CreditmemoCommentInterfaceFactory')
106-
->setMethods(['create'])
107-
->disableOriginalConstructor()
108-
->getMock();
105+
$this->commentFactoryMock = $this->getMockBuilder(CreditmemoCommentInterfaceFactory::class)
106+
->disableOriginalConstructor()
107+
->getMock();
109108
$this->hydratorPoolMock = $this->getMockBuilder(HydratorPool::class)
110109
->disableOriginalConstructor()
111110
->getMock();

0 commit comments

Comments
 (0)