ENGCOM-5362: Changed logic so that _scrollToTopIfVisible is called only if element is in viewport. Previously it was called only when the element was outside it. #23390

magento-engcom-team · magento-engcom-team · commit 14932cb4f79b · 2019-06-26T09:50:20.000-05:00
- Merge Pull Request #23390 from oskarolaussen/magento2:2.3-develop - Merged commits: 1. c029f5a 2. b5f2357 3. f13d718 4. 00b5bfe
diff --git a/lib/web/mage/collapsible.js b/lib/web/mage/collapsible.js
@@ -570,7 +570,7 @@ define([
          * @private
          */
         _scrollToTopIfVisible: function (elem) {
-            if (this._isElementOutOfViewport(elem)) {
+            if (!this._isElementOutOfViewport(elem)) {
                 elem.scrollIntoView();
             }
         },

Original file line number	Diff line number	Diff line change
`@@ -570,7 +570,7 @@ define([`
`570`	`570`	`* @private`
`571`	`571`	`*/`
`572`	`572`	`_scrollToTopIfVisible: function (elem) {`
`573`		`- if (this._isElementOutOfViewport(elem)) {`
	`573`	`+ if (!this._isElementOutOfViewport(elem)) {`
`574`	`574`	`elem.scrollIntoView();`
`575`	`575`	`}`
`576`	`576`	`},`