MAGETWO-62691: [Performance] EAV attributes caching optimization

Author: kandy

app/code/Magento/Eav/Model/Config.php

@@ -544,14 +544,13 @@ private function createAttribute($model)
      *
      * @param  mixed $entityType
      * @param  \Magento\Framework\DataObject $object
-     * @return array
+     * @return string[]
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      * @SuppressWarnings(PHPMD.NPathComplexity)
      */
     public function getEntityAttributeCodes($entityType, $object = null)
     {
-        $attributes = array_keys($this->getEntityAttributes($entityType, $object));
-        return $attributes;
+        return array_keys($this->getEntityAttributes($entityType, $object));
     }
 
     /**

app/code/Magento/Eav/Model/Entity/AbstractEntity.php

@@ -1186,7 +1186,7 @@ protected function _getOrigObject($object)
      *
      * @param array &$delete
      * @param AbstractAttribute $attribute
-     * @param \Magento\Eav\Model\Entity\AbstractEntity $object
+     * @param AbstractEntity $object
      * @return void
      */
     private function _aggregateDeleteData(&$delete, $attribute, $object)
@@ -1920,8 +1920,12 @@ public function afterDelete(\Magento\Framework\DataObject $object)
     }
 
     /**
+     * Load attributes for object
+     *  if the object will not pass all attributes for this entity type will be loaded
+     *
      * @param array $attributes
-     * @param |null $object
+     * @param AbstractEntity|null $object
+     * @return void
      */
     protected function loadAttributesForObject($attributes, $object = null)
     {

app/code/Magento/Eav/Model/Entity/AttributeLoader.php

@@ -57,7 +57,7 @@ public function __construct(
      */
     public function loadAllAttributes(AbstractEntity $resource, DataObject $object = null)
     {
-        $attributes = (array)$this->config->getEntityAttributes($resource->getEntityType(), $object);
+        $attributes = $this->config->getEntityAttributes($resource->getEntityType(), $object);
         $attributeCodes = array_keys($attributes);
         /**
          * Check and init default attributes