Replace sort callback to spaceship

lbajsarowicz · mage2pratik · commit 13a9c4367fbb · 2018-08-02T16:24:15.000Z
diff --git a/app/code/Magento/Quote/Model/Quote/Address.php b/app/code/Magento/Quote/Model/Quote/Address.php
@@ -872,13 +872,7 @@ public function getGroupedAllShippingRates()
      */
     protected function _sortRates($firstItem, $secondItem)
     {
-        if ((int)$firstItem[0]->carrier_sort_order < (int)$secondItem[0]->carrier_sort_order) {
-            return -1;
-        } elseif ((int)$firstItem[0]->carrier_sort_order > (int)$secondItem[0]->carrier_sort_order) {
-            return 1;
-        } else {
-            return 0;
-        }
+        return (int) $firstItem[0]->carrier_sort_order <=> (int) $secondItem[0]->carrier_sort_order;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -872,13 +872,7 @@ public function getGroupedAllShippingRates()`
`872`	`872`	`*/`
`873`	`873`	`protected function _sortRates($firstItem, $secondItem)`
`874`	`874`	`{`
`875`		`- if ((int)$firstItem[0]->carrier_sort_order < (int)$secondItem[0]->carrier_sort_order) {`
`876`		`- return -1;`
`877`		`- } elseif ((int)$firstItem[0]->carrier_sort_order > (int)$secondItem[0]->carrier_sort_order) {`
`878`		`- return 1;`
`879`		`- } else {`
`880`		`- return 0;`
`881`		`- }`
	`875`	`+ return (int) $firstItem[0]->carrier_sort_order <=> (int) $secondItem[0]->carrier_sort_order;`
`882`	`876`	`}`
`883`	`877`
`884`	`878`	`/**`