Skip to content

Commit 1394a9d

Browse files
author
Yu Tang
committed
MAGETWO-28256: Bundle Integration API Refactoring
- Fix unit test failures
1 parent 0383cd8 commit 1394a9d

File tree

2 files changed

+20
-14
lines changed

2 files changed

+20
-14
lines changed

app/code/Magento/Bundle/Test/Unit/Model/OptionRepositoryTest.php

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,9 @@ public function testUpdateIfOptionDoesNotExist()
336336

337337
$existingOptionMock = $this->getMock('\Magento\Bundle\Model\Option', ['getOptionId'], [], '', false);
338338
$optCollectionMock->expects($this->once())->method('setIdFilter')->with($optionId)->willReturnSelf();
339-
$optCollectionMock->expects($this->once())->method('getFirstItem')->willReturn($existingOptionMock);
339+
$optCollectionMock->expects($this->once())->method('getItemById')
340+
->with($optionId)
341+
->willReturn($existingOptionMock);
340342
$existingOptionMock->expects($this->once())->method('getOptionId')->willReturn(null);
341343

342344
$this->assertEquals($optionId, $this->model->save($productMock, $optionMock));
@@ -406,7 +408,9 @@ public function testSaveExistingOption()
406408
false
407409
);
408410
$optCollectionMock->expects($this->once())->method('setIdFilter')->with($optionId)->willReturnSelf();
409-
$optCollectionMock->expects($this->once())->method('getFirstItem')->willReturn($existingOptionMock);
411+
$optCollectionMock->expects($this->once())->method('getItemById')
412+
->with($optionId)
413+
->willReturn($existingOptionMock);
410414
$existingOptionMock->expects($this->any())->method('getOptionId')->willReturn($existingOptionId);
411415

412416
$productLinkUpdate = $this->getMock('\Magento\Bundle\Api\Data\LinkInterface');
@@ -423,7 +427,7 @@ public function testSaveExistingOption()
423427
->with($productMock, $optionId, $productLinkNew);
424428
$this->linkManagementMock->expects($this->once())
425429
->method('saveChild')
426-
->with($productMock, $productLinkUpdate);
430+
->with($productSku, $productLinkUpdate);
427431
$this->linkManagementMock->expects($this->once())
428432
->method('removeChild')
429433
->with($productSku, $optionId, $productSkuToDelete);
@@ -476,7 +480,9 @@ public function testSaveExistingOptionNoSuchOption()
476480
false
477481
);
478482
$optCollectionMock->expects($this->once())->method('setIdFilter')->with($optionId)->willReturnSelf();
479-
$optCollectionMock->expects($this->once())->method('getFirstItem')->willReturn($existingOptionMock);
483+
$optCollectionMock->expects($this->once())->method('getItemById')
484+
->with($optionId)
485+
->willReturn($existingOptionMock);
480486
$existingOptionMock->expects($this->any())->method('getOptionId')->willReturn(null);
481487

482488
$this->model->save($productMock, $optionMock);

app/code/Magento/Catalog/Test/Unit/Model/ProductLink/RepositoryTest.php

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,8 @@ public function testSave()
7575
$linkedProductMock = $this->getMock('\Magento\Catalog\Model\Product', [], [], '', false);
7676
$this->productRepositoryMock->expects($this->exactly(2))->method('get')->will($this->returnValueMap(
7777
[
78-
['product', false, null, $productMock],
79-
['linkedProduct', false, null, $linkedProductMock],
78+
['product', false, null, false, $productMock],
79+
['linkedProduct', false, null, false, $linkedProductMock],
8080
]
8181
));
8282
$entityMock->expects($this->once())->method('getLinkedProductSku')->willReturn('linkedProduct');
@@ -102,8 +102,8 @@ public function testSaveWithException()
102102
$linkedProductMock = $this->getMock('\Magento\Catalog\Model\Product', [], [], '', false);
103103
$this->productRepositoryMock->expects($this->exactly(2))->method('get')->will($this->returnValueMap(
104104
[
105-
['product', false, null, $productMock],
106-
['linkedProduct', false, null, $linkedProductMock],
105+
['product', false, null, false, $productMock],
106+
['linkedProduct', false, null, false, $linkedProductMock],
107107
]
108108
));
109109
$entityMock->expects($this->once())->method('getLinkedProductSku')->willReturn('linkedProduct');
@@ -129,8 +129,8 @@ public function testDelete()
129129
$linkedProductMock = $this->getMock('\Magento\Catalog\Model\Product', [], [], '', false);
130130
$this->productRepositoryMock->expects($this->exactly(2))->method('get')->will($this->returnValueMap(
131131
[
132-
['product', false, null, $productMock],
133-
['linkedProduct', false, null, $linkedProductMock],
132+
['product', false, null, false, $productMock],
133+
['linkedProduct', false, null, false, $linkedProductMock],
134134
]
135135
));
136136
$entityMock->expects($this->once())->method('getLinkedProductSku')->willReturn('linkedProduct');
@@ -157,8 +157,8 @@ public function testDeleteWithInvalidDataException()
157157
$linkedProductMock = $this->getMock('\Magento\Catalog\Model\Product', [], [], '', false);
158158
$this->productRepositoryMock->expects($this->exactly(2))->method('get')->will($this->returnValueMap(
159159
[
160-
['product', false, null, $productMock],
161-
['linkedProduct', false, null, $linkedProductMock],
160+
['product', false, null, false, $productMock],
161+
['linkedProduct', false, null, false, $linkedProductMock],
162162
]
163163
));
164164
$entityMock->expects($this->once())->method('getLinkedProductSku')->willReturn('linkedProduct');
@@ -186,8 +186,8 @@ public function testDeleteWithNoSuchEntityException()
186186
$linkedProductMock = $this->getMock('\Magento\Catalog\Model\Product', [], [], '', false);
187187
$this->productRepositoryMock->expects($this->exactly(2))->method('get')->will($this->returnValueMap(
188188
[
189-
['product', false, null, $productMock],
190-
['linkedProduct', false, null, $linkedProductMock],
189+
['product', false, null, false, $productMock],
190+
['linkedProduct', false, null, false, $linkedProductMock],
191191
]
192192
));
193193
$entityMock->expects($this->exactly(2))->method('getLinkedProductSku')->willReturn('linkedProduct');

0 commit comments

Comments
 (0)