MAGETWO-60982: AJAX calls does not process error responses

Author: slopukhov

app/code/Magento/Ui/view/base/web/js/form/client.js

@@ -7,9 +7,8 @@ define([
     'jquery',
     'underscore',
     'mageUtils',
-    'uiClass',
-    'mage/translate'
-], function ($, _, utils, Class, $t) {
+    'uiClass'
+], function ($, _, utils, Class) {
     'use strict';
 
     /**
@@ -74,48 +73,6 @@ define([
              */
             complete: function () {
                 $('body').trigger('processStop');
-            },
-
-            /**
-             * Error callback.
-             */
-            error: function (request, type, errorThrown) {
-                var message;
-
-                switch (type) {
-                    case 'timeout':
-                        message = $t('The request timed out.');
-                        break;
-                    case 'notmodified':
-                        message = $t('The request was not modified but was not retrieved from the cache.');
-                        break;
-                    case 'parsererror':
-                        message = $t('XML/Json format is bad.');
-                        break;
-                    case 'abort':
-                        message = $t('The request was aborted by the server.');
-                        break;
-                    default:
-                        message = $t('HTTP Error') + ' (' + request.status + ' ' + request.statusText + ').';
-                }
-
-                $('body').notification('clear');
-                $('body').notification('add', {
-                    error: true,
-                    message: message,
-
-                    /**
-                     * Insert method.
-                     *
-                     * @param {String} msg
-                     */
-                    insertMethod: function (msg) {
-                        var $wrapper = $('<div/>').addClass(messagesClass).html(msg);
-
-                        $('.page-main-actions', selectorPrefix).after($wrapper);
-                    }
-                });
-
             }
         });
 

lib/web/mage/backend/bootstrap.js

@@ -8,7 +8,8 @@ define([
     'jquery',
     'mage/apply/main',
     'Magento_Ui/js/lib/knockout/bootstrap',
-    'mage/mage'
+    'mage/mage',
+    'mage/translate'
 ], function ($, mage) {
     'use strict';
 
@@ -67,6 +68,45 @@ define([
                     }
                 } catch (e) {}
             }
+        },
+
+        /**
+         * Error callback.
+         */
+        error: function (jqXHR, status, error) {
+            var message;
+
+            switch (status) {
+                case 'timeout':
+                    message = $.mage.__('The request timed out.');
+                    break;
+                case 'notmodified':
+                    message = $.mage.__('The request was not modified but was not retrieved from the cache.');
+                    break;
+                case 'parsererror':
+                    message = $.mage.__('XML/Json format is bad.');
+                    break;
+                case 'abort':
+                    message = $.mage.__('The request was aborted by the server.');
+                    break;
+                default:
+                    message = $.mage.__('HTTP Error') + ' (' + jqXHR.status + ' ' + jqXHR.statusText + ').';
+            }
+
+            $('body').notification('clear')
+                .notification('add', {
+                    error: true,
+                    message: message,
+
+                    /**
+                     * @param {*} message
+                     */
+                    insertMethod: function (message) {
+                        var $wrapper = $('<div/>').addClass(this.messagesClass).html(message);
+
+                        $('.page-main-actions', this.selectorPrefix).after($wrapper);
+                    }
+                });
         }
     });