Skip to content

Commit 12e8642

Browse files
author
Mike Weis
committed
MAGETWO-44044: Including tax price does not include tax in mini shopping cart subtotal
- fixed static code failures
1 parent 5590fdc commit 12e8642

File tree

1 file changed

+4
-1
lines changed
  • app/code/Magento/Tax/Model/Sales/Total/Quote

1 file changed

+4
-1
lines changed

app/code/Magento/Tax/Model/Sales/Total/Quote/Tax.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ public function __construct(
8888
* @param ShippingAssignmentInterface $shippingAssignment
8989
* @param Address\Total $total
9090
* @return $this
91+
* @SuppressWarnings(PHPMD.UnusedFormalParameter)
9192
*/
9293
public function collect(
9394
\Magento\Quote\Model\Quote $quote,
@@ -291,14 +292,15 @@ protected function processExtraTaxables(Address\Total $total, Array $itemsByType
291292
* @param Address\Total $total
292293
* @return array|null
293294
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
295+
* @SuppressWarnings(PHPMD.NPathComplexity
294296
*/
295297
public function fetch(\Magento\Quote\Model\Quote $quote, \Magento\Quote\Model\Quote\Address\Total $total)
296298
{
297299
$totals = [];
298300
$store = $quote->getStore();
299301
$applied = $total->getAppliedTaxes();
300302
$amount = $total->getTaxAmount();
301-
if (is_null($amount)) {
303+
if ($amount == null) {
302304
$this->enhanceTotalData($quote, $total);
303305
$amount = $total->getTaxAmount();
304306
}
@@ -349,6 +351,7 @@ public function fetch(\Magento\Quote\Model\Quote $quote, \Magento\Quote\Model\Qu
349351
*
350352
* @param \Magento\Quote\Model\Quote $quote
351353
* @param Address\Total $total
354+
* @return null
352355
*/
353356
protected function enhanceTotalData(
354357
\Magento\Quote\Model\Quote $quote,

0 commit comments

Comments
 (0)