ENGCOM-1530: Fixed js error when product has double quote in its name #15162

magento-engcom-team · magento-engcom-team · commit 1257ce6b86e6 · 2018-05-12T01:26:10.000-05:00
- Merge Pull Request #15162 from vovayatsyuk/magento2:fix-js-error-breadcrumb-with-quote - Merged commits: 1. 45cb52c
diff --git a/app/code/Magento/Catalog/view/frontend/templates/product/breadcrumbs.phtml b/app/code/Magento/Catalog/view/frontend/templates/product/breadcrumbs.phtml
@@ -11,7 +11,7 @@ $viewModel = $block->getData('viewModel');
     "breadcrumbs": {
         "categoryUrlSuffix": "<?= $block->escapeHtml($viewModel->getCategoryUrlSuffix()); ?>",
         "useCategoryPathInUrl": <?= (int)$viewModel->isCategoryUsedInProductUrl(); ?>,
-        "product": "<?= $block->escapeHtml($viewModel->getProductName()); ?>"
+        "product": "<?= $block->escapeHtml($block->escapeJsQuote($viewModel->getProductName(), '"')); ?>"
     }
 }'>
 </div>

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ $viewModel = $block->getData('viewModel');`
`11`	`11`	`"breadcrumbs": {`
`12`	`12`	`"categoryUrlSuffix": "<?= $block->escapeHtml($viewModel->getCategoryUrlSuffix()); ?>",`
`13`	`13`	`"useCategoryPathInUrl": <?= (int)$viewModel->isCategoryUsedInProductUrl(); ?>,`
`14`		`- "product": "<?= $block->escapeHtml($viewModel->getProductName()); ?>"`
	`14`	`+ "product": "<?= $block->escapeHtml($block->escapeJsQuote($viewModel->getProductName(), '"')); ?>"`
`15`	`15`	`}`
`16`	`16`	`}'>`
`17`	`17`	`</div>`