Skip to content

Commit 124f295

Browse files
committed
MC-5620: --convert-old-scripts mode does not convert indexes and constraints correctly
1 parent 8f3e1c8 commit 124f295

File tree

3 files changed

+1
-3
lines changed
  • dev/tests/setup-integration/_files/Magento
  • lib/internal/Magento/Framework/Setup

3 files changed

+1
-3
lines changed

dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule8/revisions/setup_install_with_converting/UpgradeSchema.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ public function upgrade(SchemaSetupInterface $setup, ModuleContextInterface $con
5050
$this->createSimpleTable($setup, $setup->getTable(self::TEMP_TABLE));
5151
}
5252

53-
5453
$setup->endSetup();
5554
}
5655

@@ -212,5 +211,4 @@ private function createSimpleTable(SchemaSetupInterface $setup, $tableName): voi
212211
);
213212
$setup->getConnection()->createTable($table);
214213
}
215-
216214
}

dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule9/revisions/setup_install_with_converting/UpgradeSchema.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ public function upgrade(SchemaSetupInterface $setup, ModuleContextInterface $con
4646
$setup->getConnection()->createTable($replicaTable);
4747
}
4848

49-
5049
$setup->endSetup();
5150
}
5251

lib/internal/Magento/Framework/Setup/SchemaListener.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -451,6 +451,7 @@ private function prepareColumns($tableName, array $tableColumns)
451451
* @param array $foreignKeys
452452
* @param array $indexes
453453
* @param string $tableName
454+
* @param string $engine
454455
*/
455456
private function prepareConstraintsAndIndexes(array $foreignKeys, array $indexes, $tableName, $engine)
456457
{

0 commit comments

Comments
 (0)