Merge remote-tracking branch 'arcticfoxes/MC-5545' into pr

Author: Joan He

app/code/Magento/Catalog/Block/Adminhtml/Rss/NotifyStock.php

@@ -9,6 +9,7 @@
 
 /**
  * Class NotifyStock
+ *
  * @package Magento\Catalog\Block\Adminhtml\Rss
  */
 class NotifyStock extends \Magento\Backend\Block\AbstractBlock implements DataProviderInterface
@@ -41,7 +42,7 @@ public function __construct(
     }
 
     /**
-     * @return void
+     * @inheritdoc
      */
     protected function _construct()
     {
@@ -50,12 +51,12 @@ protected function _construct()
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getRssData()
     {
-        $newUrl = $this->rssUrlBuilder->getUrl(['_secure' => true, '_nosecret' => true, 'type' => 'notifystock']);
-        $title = __('Low Stock Products');
+         $newUrl = $this->rssUrlBuilder->getUrl(['_secure' => true, '_nosecret' => true, 'type' => 'notifystock']);
+        $title = __('Low Stock Products')->render();
         $data = ['title' => $title, 'description' => $title, 'link' => $newUrl, 'charset' => 'UTF-8'];
 
         foreach ($this->rssModel->getProductsCollection() as $item) {
@@ -65,39 +66,39 @@ public function getRssData()
                 ['id' => $item->getId(), '_secure' => true, '_nosecret' => true]
             );
             $qty = 1 * $item->getQty();
-            $description = __('%1 has reached a quantity of %2.', $item->getName(), $qty);
+            $description = __('%1 has reached a quantity of %2.', $item->getName(), $qty)->render();
             $data['entries'][] = ['title' => $item->getName(), 'link' => $url, 'description' => $description];
         }
 
         return $data;
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getCacheLifetime()
     {
         return 600;
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function isAllowed()
     {
         return true;
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getFeeds()
     {
         return [];
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function isAuthRequired()
     {

app/code/Magento/Catalog/Test/Unit/Block/Adminhtml/Rss/NotifyStockTest.php

@@ -96,7 +96,12 @@ public function testGetRssData()
         $this->urlBuilder->expects($this->once())->method('getUrl')
             ->with('catalog/product/edit', ['id' => 1, '_secure' => true, '_nosecret' => true])
             ->will($this->returnValue('http://magento.com/catalog/product/edit/id/1'));
-        $this->assertEquals($this->rssFeed, $this->block->getRssData());
+
+        $data = $this->block->getRssData();
+        $this->assertTrue(is_string($data['title']));
+        $this->assertTrue(is_string($data['description']));
+        $this->assertTrue(is_string($data['entries'][0]['description']));
+        $this->assertEquals($this->rssFeed, $data);
     }
 
     public function testGetCacheLifetime()