Skip to content

Commit 11d3487

Browse files
committed
Merge branch 'MC-30500' of https://github.com/magento-mpi/magento2ce into PR-2020-02-05
2 parents 0f2b64b + e4d30ec commit 11d3487

File tree

2 files changed

+204
-115
lines changed

2 files changed

+204
-115
lines changed

app/code/Magento/Tax/Model/Sales/Total/Quote/CommonTaxCollector.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -383,6 +383,7 @@ public function mapItems(
383383
$priceIncludesTax,
384384
$useBaseCurrency
385385
);
386+
// phpcs:ignore Magento2.Performance.ForeachArrayMerge
386387
$itemDataObjects = array_merge($itemDataObjects, $extraTaxableItems);
387388
}
388389
} else {
@@ -394,6 +395,7 @@ public function mapItems(
394395
$priceIncludesTax,
395396
$useBaseCurrency
396397
);
398+
// phpcs:ignore Magento2.Performance.ForeachArrayMerge
397399
$itemDataObjects = array_merge($itemDataObjects, $extraTaxableItems);
398400
}
399401
}
@@ -591,7 +593,10 @@ protected function processProductItems(
591593
$total->setSubtotalInclTax($subtotalInclTax);
592594
$total->setBaseSubtotalTotalInclTax($baseSubtotalInclTax);
593595
$total->setBaseSubtotalInclTax($baseSubtotalInclTax);
594-
$shippingAssignment->getShipping()->getAddress()->setBaseSubtotalTotalInclTax($baseSubtotalInclTax);
596+
$address = $shippingAssignment->getShipping()->getAddress();
597+
$address->setBaseSubtotalTotalInclTax($baseSubtotalInclTax);
598+
$address->setSubtotal($total->getSubtotal());
599+
$address->setBaseSubtotal($total->getBaseSubtotal());
595600

596601
return $this;
597602
}
@@ -799,6 +804,7 @@ public function convertAppliedTaxes($appliedTaxes, $baseAppliedTaxes, $extraInfo
799804
'rates' => $rates,
800805
];
801806
if (!empty($extraInfo)) {
807+
// phpcs:ignore Magento2.Performance.ForeachArrayMerge
802808
$appliedTaxArray = array_merge($appliedTaxArray, $extraInfo);
803809
}
804810

0 commit comments

Comments
 (0)