Skip to content

Commit 11875d1

Browse files
committed
Merge branch 'ACP2E-1307' of https://github.com/magento-l3/magento2ce into ACP2E-1307
2 parents 001293f + 1c053e8 commit 11875d1

File tree

2 files changed

+16
-9
lines changed
  • app/code/Magento/CatalogWidget/Test/Unit/Model/Rule/Condition
  • dev/tests/integration/testsuite/Magento/CatalogWidget/Model/Rule/Condition

2 files changed

+16
-9
lines changed

app/code/Magento/CatalogWidget/Test/Unit/Model/Rule/Condition/ProductTest.php

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,12 @@ public function getMappedSqlFieldPriceDataProvider(): array
189189
[
190190
false,
191191
false,
192-
'e.entity_id'
192+
'at_price.value'
193+
],
194+
[
195+
false,
196+
true,
197+
'price_index.min_price'
193198
],
194199
];
195200
}
@@ -248,7 +253,7 @@ public function getBindArgumentValueDataProvider(): array
248253
1 => 2
249254
]
250255
],
251-
new \Zend_Db_Expr('1, 3')
256+
'2'
252257
],
253258
[
254259
[

dev/tests/integration/testsuite/Magento/CatalogWidget/Model/Rule/Condition/ProductTest.php

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -102,11 +102,11 @@ public function testAddNonGlobalAttributeToCollectionNoProducts()
102102
$this->conditionProduct->addToCollection($collection);
103103
$collectedAttributes = $this->conditionProduct->getRule()->getCollectedAttributes();
104104
$this->assertArrayHasKey('visibility', $collectedAttributes);
105-
$query = (string)$collection->getSelect();
106-
$this->assertStringNotContainsString('visibility', $query);
107-
$this->assertEquals('', $this->conditionProduct->getMappedSqlField());
105+
$this->assertEquals(0, $collection->getSize());
106+
$this->assertStringContainsString('visibility', (string)$this->conditionProduct->getMappedSqlField());
108107
$this->assertFalse($this->conditionProduct->hasValueParsed());
109-
$this->assertFalse($this->conditionProduct->hasValue());
108+
$this->assertTrue($this->conditionProduct->hasValue());
109+
$this->assertEquals('4', $this->conditionProduct->getValue());
110110
}
111111

112112
/**
@@ -121,9 +121,11 @@ public function testAddNonGlobalAttributeToCollection()
121121
$this->conditionProduct->addToCollection($collection);
122122
$collectedAttributes = $this->conditionProduct->getRule()->getCollectedAttributes();
123123
$this->assertArrayHasKey('visibility', $collectedAttributes);
124-
$query = (string)$collection->getSelect();
125-
$this->assertStringNotContainsString('visibility', $query);
126-
$this->assertEquals('e.entity_id', $this->conditionProduct->getMappedSqlField());
124+
$this->assertEquals(1, $collection->getSize());
125+
$this->assertStringContainsString('visibility', (string)$this->conditionProduct->getMappedSqlField());
126+
$this->assertFalse($this->conditionProduct->hasValueParsed());
127+
$this->assertTrue($this->conditionProduct->hasValue());
128+
$this->assertEquals('4', $this->conditionProduct->getValue());
127129
}
128130

129131
/**

0 commit comments

Comments
 (0)