Merge remote-tracking branch 'ext/MAGETWO-54031-static-tests' into pull-request

Author: Cari Spruiell

dev/tests/static/framework/Magento/TestFramework/Integrity/PluginValidator.php

@@ -0,0 +1,57 @@
+<?php
+/**
+ * Copyright © 2016 Magento. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+namespace Magento\TestFramework\Integrity;
+
+use Magento\Framework\Exception\ValidatorException;
+use Magento\Framework\Interception\Code\InterfaceValidator;
+use Magento\Framework\Phrase;
+
+class PluginValidator
+{
+    /** @var InterfaceValidator */
+    private $frameworkValidator;
+
+    /**
+     * @param InterfaceValidator $frameworkValidator
+     */
+    public function __construct(InterfaceValidator $frameworkValidator)
+    {
+        $this->frameworkValidator = $frameworkValidator;
+    }
+
+    /**
+     * Validate plugin and intercepted class
+     *
+     * @param string $pluginClass
+     * @param string $interceptedType
+     * @throws ValidatorException
+     */
+    public function validate($pluginClass, $interceptedType)
+    {
+        $this->frameworkValidator->validate($pluginClass, $interceptedType);
+        $this->validateClassNameMatchesCase($pluginClass);
+        $this->validateClassNameMatchesCase($interceptedType);
+    }
+
+    /**
+     * Verify that the class name has same capitalization as the class declaration
+     *
+     * @param string $className
+     * @throws ValidatorException
+     */
+    private function validateClassNameMatchesCase($className)
+    {
+        $declarationName = (new \ReflectionClass($className))->getName();;
+        if (ltrim($className, '\\') != ltrim($declarationName)) {
+            throw new ValidatorException(
+                new Phrase(
+                    "Capitalization of class name '%1' does not match expected '%2'",
+                    [$className, $declarationName]
+                )
+            );
+        }
+    }
+}

dev/tests/static/testsuite/Magento/Test/Integrity/Di/CompilerTest.php

@@ -11,12 +11,14 @@
 use Magento\Framework\Api\Code\Generator\SearchResults;
 use Magento\Framework\App\Filesystem\DirectoryList;
 use Magento\Framework\Component\ComponentRegistrar;
+use Magento\Framework\Interception\Code\InterfaceValidator;
 use Magento\Framework\ObjectManager\Code\Generator\Converter;
 use Magento\Framework\ObjectManager\Code\Generator\Factory;
 use Magento\Framework\ObjectManager\Code\Generator\Repository;
 use Magento\Framework\Api\Code\Generator\ExtensionAttributesInterfaceGenerator;
 use Magento\Framework\Api\Code\Generator\ExtensionAttributesGenerator;
 use Magento\Framework\App\Utility\Files;
+use Magento\TestFramework\Integrity\PluginValidator;
 
 /**
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
@@ -56,7 +58,7 @@ class CompilerTest extends \PHPUnit_Framework_TestCase
     /**
      * Class arguments reader
      *
-     * @var \Magento\Framework\Interception\Code\InterfaceValidator
+     * @var PluginValidator
      */
     protected $pluginValidator;
 
@@ -103,7 +105,7 @@ protected function setUp()
         $this->_validator->add(new \Magento\Framework\Code\Validator\TypeDuplication());
         $this->_validator->add(new \Magento\Framework\Code\Validator\ArgumentSequence());
         $this->_validator->add(new \Magento\Framework\Code\Validator\ConstructorArgumentTypes());
-        $this->pluginValidator = new \Magento\Framework\Interception\Code\InterfaceValidator();
+        $this->pluginValidator = new PluginValidator(new InterfaceValidator());
     }
 
     /**