ENGCOM-9086: #32309: IncosistentReferenceDefinition wrong check result #32959

 - Merge Pull Request #32959 from engcom-Foxtrot/magento2:#32309
 - Merged commits:
   1. 3d14e8c
   2. 00baa67
   3. d98d958
   4. 0ef6ef9
   5. f9dd816
   6. e405b8f

Author: magento-engcom-team

dev/tests/setup-integration/_files/Magento/TestSetupDeclarationModule8/revisions/inconsistent_reference_type_definition/db_schema.xml

@@ -0,0 +1,21 @@
+<?xml version="1.0"?>
+<!--
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+-->
+<schema xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:noNamespaceSchemaLocation="urn:magento:framework:Setup/Declaration/Schema/etc/schema.xsd">
+    <table name="test_table" resource="default" comment="Test Table">
+        <column xsi:type="int" name="page_id" nullable="true" unsigned="true" identity="true"/>
+        <constraint xsi:type="primary" referenceId="PRIMARY">
+            <column name="page_id"/>
+        </constraint>
+    </table>
+    <table name="dependent" resource="default" comment="Lol">
+        <column xsi:type="float" name="page_id_on" nullable="true" unsigned="true"/>
+        <constraint xsi:type="foreign" referenceId="FOREIGN" table="dependent" column="page_id_on" referenceColumn="page_id"
+                    referenceTable="test_table"/>
+    </table>
+</schema>

dev/tests/setup-integration/testsuite/Magento/Setup/ValidationRulesTest.php

@@ -87,6 +87,29 @@ public function testFailOnIncosistentReferenceDefinition()
         $this->schemaConfig->getDeclarationConfig();
     }
 
+    /**
+     * @moduleName Magento_TestSetupDeclarationModule8
+     */
+    public function testFailOnInconsistentReferenceTypeDefinition()
+    {
+        $this->expectException(LocalizedException::class);
+        $this->expectExceptionMessageMatches(
+            '/Column definition "page_id_on" and reference column definition "page_id"'
+            . ' are different in tables "dependent" and "test_table"/'
+        );
+
+        $this->cliCommad->install(
+            ['Magento_TestSetupDeclarationModule8']
+        );
+        $this->moduleManager->updateRevision(
+            'Magento_TestSetupDeclarationModule8',
+            'inconsistent_reference_type_definition',
+            'db_schema.xml',
+            'etc'
+        );
+        $this->schemaConfig->getDeclarationConfig();
+    }
+
     /**
      * @moduleName Magento_TestSetupDeclarationModule8
      */

lib/internal/Magento/Framework/Setup/Declaration/Schema/Declaration/ValidationRules/IncosistentReferenceDefinition.php

@@ -40,7 +40,7 @@ private function assertDefinitionEqual(Column $column, Column $referenceColumn)
          * Columns should have the same types
          */
         if ($column->getType() !== $referenceColumn->getType()) {
-            return true;
+            return false;
         }
 
         return $this->assertUnsigned($column, $referenceColumn) &&