Use the strict option for in_array to allow numerical SKUs

Author: alexander-aleman

app/code/Magento/ConfigurableImportExport/Model/Import/Product/Type/Configurable.php

@@ -937,7 +937,7 @@ public function isRowValid(array $rowData, $rowNum, $isNewProduct = true)
         }
         foreach ($dataWithExtraVirtualRows as $option) {
             if (isset($option['_super_products_sku'])) {
-                if (in_array($option['_super_products_sku'], $skus)) {
+                if (in_array($option['_super_products_sku'], $skus, true)) {
                     $error = true;
                     $this->_entityModel->addRowError(
                         sprintf(

app/code/Magento/ConfigurableImportExport/Test/Unit/Model/Import/Product/Type/ConfigurableTest.php

@@ -586,8 +586,55 @@ public function testIsRowValid()
             '_type' => 'configurable',
             '_product_websites' => 'website_1',
         ];
+        // Checking that variations with duplicate sku are invalid
+        $duplicateVariationSKU = 'configurableskuI22DuplicateVariation';
+        $duplicateVariationProduct = [
+            'sku' => $duplicateVariationSKU,
+            'store_view_code' => null,
+            'attribute_set_code' => 'Default',
+            'product_type' => 'configurable',
+            'name' => 'Configurable Product with duplicate SKUs in variations',
+            'product_websites' => 'website_1',
+            'configurable_variation_labels' => 'testattr2=Select Color, testattr3=Select Size',
+            'configurable_variations' => 'sku=testconf2-attr2val1-testattr3v1,'
+                . 'testattr2=attr2val1,'
+                . 'testattr3=testattr3v1,'
+                . 'display=1|sku=testconf2-attr2val1-testattr3v1,'
+                . 'testattr2=attr2val1,'
+                . 'testattr3=testattr3v2,'
+                . 'display=0',
+            '_store' => null,
+            '_attribute_set' => 'Default',
+            '_type' => 'configurable',
+            '_product_websites' => 'website_1',
+        ];
+        // Checking that variations with SKUs that are the same when interpreted as number,
+        // but different when interpreted as string are valid
+        $nonDuplicateVariationSKU = 'configurableskuI22NonDuplicateVariation';
+        $nonDuplicateVariationProduct = [
+            'sku' => $nonDuplicateVariationSKU,
+            'store_view_code' => null,
+            'attribute_set_code' => 'Default',
+            'product_type' => 'configurable',
+            'name' => 'Configurable Product with different SKUs in variations',
+            'product_websites' => 'website_1',
+            'configurable_variation_labels' => 'testattr2=Select Color, testattr3=Select Size',
+            'configurable_variations' => 'sku=1234.10,'
+                . 'testattr2=attr2val1,'
+                . 'testattr3=testattr3v1,'
+                . 'display=1|sku=1234.1,'
+                . 'testattr2=attr2val1,'
+                . 'testattr3=testattr3v2,'
+                . 'display=0',
+            '_store' => null,
+            '_attribute_set' => 'Default',
+            '_type' => 'configurable',
+            '_product_websites' => 'website_1',
+        ];
         $bunch[] = $badProduct;
         $bunch[] = $caseInsensitiveProduct;
+        $bunch[] = $duplicateVariationProduct;
+        $bunch[] = $nonDuplicateVariationProduct;
         // Set _attributes to avoid error in Magento\CatalogImportExport\Model\Import\Product\Type\AbstractType.
         $this->setPropertyValue($this->configurable, '_attributes', [
             $badProduct[\Magento\CatalogImportExport\Model\Import\Product::COL_ATTR_SET] => [],
@@ -613,6 +660,12 @@ public function testIsRowValid()
             if ($rowData['sku'] === $caseInsensitiveSKU) {
                 $this->assertTrue($result);
             }
+            if ($rowData['sku'] === $duplicateVariationSKU) {
+                $this->assertFalse($result);
+            }
+            if ($rowData['sku'] === $nonDuplicateVariationSKU) {
+                $this->assertTrue($result);
+            }
         }
     }