MAGETWO-34757: Impossible to add configured product from wishlist to shopping cart

Author: okarpenko

app/code/Magento/GroupedProduct/Model/Product/Type/Grouped.php

@@ -326,6 +326,12 @@ public function save($product)
         return $this;
     }
 
+    /**
+     * @param \Magento\Framework\Object $buyRequest
+     * @param $product
+     * @param $isStrictProcessMode
+     * @return array|string
+     */
     protected function getProductInfo(\Magento\Framework\Object $buyRequest, $product, $isStrictProcessMode)
     {
         $productsInfo = $buyRequest->getSuperGroup() ?: [];
@@ -355,6 +361,7 @@ protected function getProductInfo(\Magento\Framework\Object $buyRequest, $produc
      * @param string $processMode
      * @return \Magento\Framework\Phrase|array|string
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
+     * @SuppressWarnings(PHPMD.NPathComplexity)
      */
     protected function _prepareProduct(\Magento\Framework\Object $buyRequest, $product, $processMode)
     {
@@ -375,7 +382,7 @@ protected function _prepareProduct(\Magento\Framework\Object $buyRequest, $produ
                 continue;
             }
 
-            $_result = $subProduct->getTypeInstance()->_prepareProduct($buyRequest, $subProduct,$processMode);
+            $_result = $subProduct->getTypeInstance()->_prepareProduct($buyRequest, $subProduct, $processMode);
 
             if (is_string($_result)) {
                 return $_result;

app/code/Magento/GroupedProduct/Test/Unit/Model/Product/Type/GroupedTest.php

@@ -391,8 +391,14 @@ public function testPrepareForCartAdvancedNoProductsStrictTrue()
 
         $cached = true;
         $associatedProducts = [];
-        $this->product->expects($this->atLeastOnce())->method('hasData')->will($this->returnValue($cached));
-        $this->product->expects($this->atLeastOnce())->method('getData')->will($this->returnValue($associatedProducts));
+        $this->product
+            ->expects($this->atLeastOnce())
+            ->method('hasData')
+            ->will($this->returnValue($cached));
+        $this->product
+            ->expects($this->atLeastOnce())
+            ->method('getData')
+            ->will($this->returnValue($associatedProducts));
 
         $this->assertEquals(
             $expectedMsg,
@@ -407,8 +413,14 @@ public function testPrepareForCartAdvancedNoProductsStrictFalse()
 
         $cached = true;
         $associatedProducts = [];
-        $this->product->expects($this->atLeastOnce())->method('hasData')->will($this->returnValue($cached));
-        $this->product->expects($this->atLeastOnce())->method('getData')->will($this->returnValue($associatedProducts));
+        $this->product
+            ->expects($this->atLeastOnce())
+            ->method('hasData')
+            ->will($this->returnValue($cached));
+        $this->product
+            ->expects($this->atLeastOnce())
+            ->method('getData')
+            ->will($this->returnValue($associatedProducts));
 
         $this->assertEquals(
             [0 => $this->product],
@@ -438,8 +450,14 @@ public function testPrepareForCartAdvancedWithProductsStrictFalseStringResult()
         $buyRequest->setSuperGroup([$associatedId => 1]);
 
         $cached = true;
-        $this->product->expects($this->atLeastOnce())->method('hasData')->will($this->returnValue($cached));
-        $this->product->expects($this->atLeastOnce())->method('getData')->will($this->returnValue([$associatedProduct]));
+        $this->product
+            ->expects($this->atLeastOnce())
+            ->method('hasData')
+            ->will($this->returnValue($cached));
+        $this->product
+            ->expects($this->atLeastOnce())
+            ->method('getData')
+            ->will($this->returnValue([$associatedProduct]));
 
         $this->assertEquals(
             $associatedPrepareResult,
@@ -470,8 +488,14 @@ public function testPrepareForCartAdvancedWithProductsStrictFalseEmptyArrayResul
         $buyRequest->setSuperGroup([$associatedId => 1]);
 
         $cached = true;
-        $this->product->expects($this->atLeastOnce())->method('hasData')->will($this->returnValue($cached));
-        $this->product->expects($this->atLeastOnce())->method('getData')->will($this->returnValue([$associatedProduct]));
+        $this->product->
+        expects($this->atLeastOnce())
+            ->method('hasData')
+            ->will($this->returnValue($cached));
+        $this->product->
+        expects($this->atLeastOnce())
+            ->method('getData')
+            ->will($this->returnValue([$associatedProduct]));
 
         $this->assertEquals(
             $expectedMsg,
@@ -501,8 +525,14 @@ public function testPrepareForCartAdvancedWithProductsStrictFalse()
         $buyRequest->setSuperGroup([$associatedId => 1]);
 
         $cached = true;
-        $this->product->expects($this->atLeastOnce())->method('hasData')->will($this->returnValue($cached));
-        $this->product->expects($this->atLeastOnce())->method('getData')->will($this->returnValue([$associatedProduct]));
+        $this->product
+            ->expects($this->atLeastOnce())
+            ->method('hasData')
+            ->will($this->returnValue($cached));
+        $this->product
+            ->expects($this->atLeastOnce())
+            ->method('getData')
+            ->will($this->returnValue([$associatedProduct]));
 
         $this->assertEquals(
             [$this->product],
@@ -532,8 +562,14 @@ public function testPrepareForCartAdvancedWithProductsStrictTrue()
         $buyRequest->setSuperGroup([$associatedId => 1]);
 
         $cached = true;
-        $this->product->expects($this->atLeastOnce())->method('hasData')->will($this->returnValue($cached));
-        $this->product->expects($this->atLeastOnce())->method('getData')->will($this->returnValue([$associatedProduct]));
+        $this->product
+            ->expects($this->atLeastOnce())
+            ->method('hasData')
+            ->will($this->returnValue($cached));
+        $this->product
+            ->expects($this->atLeastOnce())
+            ->method('getData')
+            ->will($this->returnValue([$associatedProduct]));
 
         $this->assertEquals(
             $associatedPrepareResult,